make: sign every built binary, not just install and dev - #24
Merged
Conversation
Follow-up to the install-signing change, which was incomplete. That change signed `install` and `dev`. It missed the binary actually run during development — `./target/release/<bin>`, produced by `release` and by `verify` through `smoke`. Left ad-hoc signed, it mints a new code identity every rebuild, so macOS keeps asking for "Always Allow": the prompts do not stop, they move to whichever binary was missed. Observed in `rpm-fl-cli` immediately after adopting the first fix: ```console $ codesign -dv ~/.cargo/bin/rpmfl # Identifier=rpmfl ← signed $ codesign -dv ./target/release/rpmfl # Identifier=rpmfl-92efb87… Signature=adhoc ``` Now every target that produces a binary signs it. Verified with `make -n`: `SIGN_TARGET` resolves to the real output path for this Makefile's layout. Still a no-op with a note on CI/Linux. Guidance corrected in cli-common#7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the install-signing change, which was incomplete.
That change signed
installanddev. It missed the binary actually run during development —./target/release/<bin>, produced byreleaseand byverifythroughsmoke. Left ad-hoc signed, it mints a new code identity every rebuild, so macOS keeps asking for "Always Allow": the prompts do not stop, they move to whichever binary was missed.Observed in
rpm-fl-cliimmediately after adopting the first fix:Now every target that produces a binary signs it. Verified with
make -n:SIGN_TARGETresolves to the real output path for this Makefile's layout. Still a no-op with a note on CI/Linux.Guidance corrected in cli-common#7.