properties list: omit propertyType when unfiltered, pass values through verbatim - #22
Merged
Merged
Conversation
The upstream marketplace endpoint changed its propertyType enum out from
under the CLI: every documented value (ALL, RESIDENTIAL, COMMERCIAL) now
400s with invalid_property_type, so `properties list` — which defaulted
to sending ALL — was entirely broken.
Probing the live API shows the accepted values are now the lowercase
strings from the listings' own `property_type` field ("single family",
"vacation rental", "duplex", "triplex", "fourplex", "mixed use",
"commercial"), and that omitting the parameter already means all types.
So stop encoding upstream's enum here at all:
- No --property-type → omit the parameter entirely (no ALL sentinel).
- A given value is passed through verbatim — no client-side casing,
mapping, or validation — so the next upstream enum change doesn't
need a CLI release to use. Help text now says the values are
upstream-defined and lists the currently observed ones.
Query construction moves into a list_query helper with offline tests
covering both the omission and the verbatim pass-through.
Fixes #20
piekstra-dev
approved these changes
Aug 11, 2026
piekstra-dev
left a comment
piekstra-dev
left a comment
Collaborator
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: f62378e3a903
Profile: reviewer - Posting as: piekstra-dev
Summary
| Severity | Findings |
|---|---|
| blocking | 0 |
| major | 0 |
| minor | 0 |
| nits | 0 |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 28s | $0.19 | claude-sonnet-5 | cr 0.10.268
| Field | Value |
|---|---|
| Model | claude-sonnet-5 |
| Reviewers | unavailable |
| Engine | claude_cli · claude-sonnet-5 |
| Reviewed by | cr · piekstra-dev |
| Duration | 28s wall · 24s compute |
| Cost | $0.19 |
| Tokens | 12 in / 1.3k out |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | claude-sonnet-5 | 6 | 889 | 49.7k | 10.8k | $0.09 | 13s |
| orchestrator-rollup | claude-sonnet-5 | 6 | 376 | 57.4k | 12.8k | $0.10 | 11s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
lofty properties listwas entirely broken: the upstream marketplace endpoint changed itspropertyTypeenum, and every documented value (ALL— the default the CLI always sent — plusRESIDENTIAL/COMMERCIAL) now returns HTTP 400invalid_property_type.Change
--property-type→ the parameter is omitted entirely. Omission already means "all types" upstream; theALLsentinel is gone.single family,vacation rental,duplex,triplex,fourplex,mixed use,commercial— the lowercase strings from the listings' ownproperty_typefield).list_queryhelper with offline tests for both the omission and the pass-through.Verification
make verifygreen (fmt, clippy-D warnings, 115 tests, offline smoke).properties list --jsonreturns the full set again;--property-type "vacation rental"is accepted and echoed back by upstream.