feat(tauri-updater): add shared update controller and dialog#56
Merged
Conversation
Add check({ manual: true }) so PickForge's Settings action can clear a
dismissed state, bypass the process-gate cache with a fresh
adapter.check(), and surface errors non-silently. Also drop a
late-resolving automatic check's transition to available if the user
dismissed meanwhile, keeping the dismissed state's stored update.
Swap the flat backdrop scrim and blur(24px) card treatment for the canonical color-mix(--pf-surface) scrim and glass-strong recipe (blur(20px) saturate(160%), --pf-surface-1 at 85%) per the branding-visual PR-1 audit.
Add a monotonic check-generation guard so a stale silent/auto check result can never clobber a newer manual (or newer manual) result, and apply the same dismissed-preserving bookkeeping to the failure path that already existed for the success path. Retry after a failed check now replays the check with the same manual/auto mode it originally ran with, so retrying a failed manual check performs a fresh adapter.check() instead of reusing the process gate's cached result. Also add a one-line re-entrancy guard so a second install() call while one is in flight is a no-op.
Build the <dialog> subtree once and mutate its text/children in place instead of rebuilding the whole shadow tree via innerHTML on every state tick, so showModal() and the entrance animation only fire on the closed-to-open transition and the aria-live status node keeps its identity for assistive tech. The description paragraph now shows a fixed sentence per state; the bounded/scrollable notes <pre> is the sole place release notes render. Add -webkit-backdrop-filter for WebKit webviews, and extend the fixture with scenario toggles that reach a failed check, a failed install, and an indeterminate download.
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2 of #36 —
@pickforge/tauri-updater: the shared update path for PickForge, PickScribe, and PickGauge.check({ manual: true })for Settings-style re-checks (bypasses dismissal + gate cache, non-silent errors), monotonic generation guard against late-resolving checks, install re-entrancy guardpickforge-update-dialogWeb Component: native<dialog>, stable DOM across renders (showModal once per open, persistent polite live region, entrance animation on open only), notes solely in the bounded scrollable block, full--pf-*token conformance incl. canonical glass-strong + scrim per branding-visual COMPONENTS.md §13 (PR 1, merged)?scenario=linksRefs #36 (PR 2 of 5 — PR 3–5 app integrations follow behind the
studioUpdateDialogflag; PR 1 merged as pickforge/branding-visual#10).Validation