Skip to content

Conversation

@Grufoony
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 97.88732% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.55%. Comparing base (d787e02) to head (c2f1f7c).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/dsf/mobility/Street.cpp 94.87% 2 Missing ⚠️
src/dsf/utility/queue.hpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   85.30%   85.55%   +0.24%     
==========================================
  Files          53       53              
  Lines        5941     6063     +122     
  Branches      652      657       +5     
==========================================
+ Hits         5068     5187     +119     
- Misses        862      865       +3     
  Partials       11       11              
Flag Coverage Δ
unittests 85.55% <97.88%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds functionality to dynamically change the number of lanes on streets in a road network simulation. The PR introduces methods to modify lane counts both at the Street level and RoadNetwork level (by ID or by name), with optional speed factor adjustments to simulate scenarios like construction zones.

Changes:

  • Added Street::changeNLanes() method to modify lane count with optional speed adjustment
  • Added RoadNetwork::changeStreetNLanesById() and RoadNetwork::changeStreetNLanesByName() methods
  • Updated dsf::queue and dsf::priority_queue classes with move semantics and deleted copy operations
  • Added comprehensive test coverage for the new functionality
  • Exposed the new methods to Python through pybind11 bindings

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/dsf/mobility/Street.hpp Added changeNLanes() method declaration and private helper m_updateLaneMapping()
src/dsf/mobility/Street.cpp Implemented changeNLanes() and refactored lane mapping logic into helper method
src/dsf/mobility/RoadNetwork.hpp Added changeStreetNLanesById() and changeStreetNLanesByName() method declarations
src/dsf/mobility/RoadNetwork.cpp Implemented RoadNetwork-level lane change methods and added logging to setStreetStatusById()
src/dsf/utility/queue.hpp Added move constructors/operators and deleted copy operations; added using directives for base constructors
src/dsf/bindings.cpp Exposed new lane change methods to Python API
test/mobility/Test_street.cpp Added comprehensive tests for Street::changeNLanes()
test/mobility/Test_graph.cpp Added comprehensive tests for RoadNetwork lane change methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@Grufoony Grufoony merged commit 53d80bc into main Feb 2, 2026
47 checks passed
@Grufoony Grufoony deleted the changeStreetNLanes branch February 2, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants