Vim motion support#4
Open
KyawTheMonkey wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in vim-style keyboard navigation to all interactive views in TUIkit, alongside a complementary horizontal navigation modifier.
What changed
New public API — two composable modifiers:
Both modifiers accept a variadic Set of styles, so each scheme is fully opt-in and can be combined freely. Neither changes the default behaviour. Existing apps get [.arrowKey] vertical and [.tab] horizontal with zero migration required.
Checklist
swift buildsucceeds on both)swift test)swiftlint)Test Plan
35 new tests across 4 new suites in 2 existing test files
ItemListHandlerVimMotionTests (15 tests) — unit tests for every vim binding directly on ItemListHandler:
FocusManagerVerticalVimTests (5 tests) — covers j/k in FocusManager.dispatchKeyEvent:
FocusManagerHorizontalVimTests (8 tests) — covers h/l and Tab gating: