Skip to content

Fix phpstan/phpstan#9455: Bug: False report Cannot call method getId() on A|null #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phpstan-bot wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
+56 −0
Open

Fix phpstan/phpstan#9455: Bug: False report Cannot call method getId() on A|null #5447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Analyser/ExprHandler/AssignHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,8 @@ private function processSureTypesForConditionalExpressionsAfterAssign(Scope $sco
!$expr instanceof PropertyFetch
&& !$expr instanceof ArrayDimFetch
&& !$expr instanceof FuncCall
&& !$expr instanceof MethodCall
&& !$expr instanceof Expr\StaticCall
) {
continue;
}
Expand Down Expand Up @@ -904,6 +906,8 @@ private function processSureNotTypesForConditionalExpressionsAfterAssign(Scope $
!$expr instanceof PropertyFetch
&& !$expr instanceof ArrayDimFetch
&& !$expr instanceof FuncCall
&& !$expr instanceof MethodCall
&& !$expr instanceof Expr\StaticCall
) {
continue;
}
Expand Down
52 changes: 52 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-9455.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
<?php // lint >= 8.0

declare(strict_types = 1);

namespace Bug9455;

use function PHPStan\Testing\assertType;

class A {
public function __construct(private int $id){}

public function getId(): int {
return $this->id;
}
}

class B {
public function __construct(private int $id, private ?A $a = null){}

public function getId(): int {
return $this->id;
}

public function getA(): ?A {
return $this->a;
}
}

class HelloWorld
{
public function testFails(): void
{
$a = new A(1);
$b = new B(1, $a);

$hasA = $b->getA() !== null;

if($hasA) {
assertType('Bug9455\A', $b->getA());
}
}

public function testSucceeds(): void
{
$a = new A(1);
$b = new B(1, $a);

if($b->getA() !== null) {
assertType('Bug9455\A', $b->getA());
}
}
}
Loading