Skip to content

Fix phpstan/phpstan#14328: Unreachable statement information gets lost #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 6 commits into from
Mar 19, 2026
+65 −2
Merged

Fix phpstan/phpstan#14328: Unreachable statement information gets lost #5253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0521bc6
Fix unreachable statement info lost in chained method calls
phpstan-bot Mar 19, 2026
87a0047
Fix lint issue: wrap `new Foo()` in parentheses in test data
phpstan-bot Mar 19, 2026
6ab487a
Add test for unreachable statement after static call with never-retur…
phpstan-bot Mar 19, 2026
149e50c
Add test for chained static call with never-returning argument
phpstan-bot Mar 19, 2026
c9bd900
Add test for static-to-static chained call (::) unreachable detection
phpstan-bot Mar 19, 2026
5546ea5
Simplify tests
VincentLanglet Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analyser/ExprHandler/MethodCallHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
if ($parametersAcceptor !== null) {
$normalizedExpr = ArgumentsNormalizer::reorderMethodArguments($parametersAcceptor, $expr) ?? $expr;
$returnType = $parametersAcceptor->getReturnType();
$isAlwaysTerminating = $returnType instanceof NeverType && $returnType->isExplicit();
$isAlwaysTerminating = $isAlwaysTerminating || ($returnType instanceof NeverType && $returnType->isExplicit());
}

$argsResult = $nodeScopeResolver->processArgs(
Expand Down
2 changes: 1 addition & 1 deletion src/Analyser/ExprHandler/StaticCallHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
if ($parametersAcceptor !== null) {
$normalizedExpr = ArgumentsNormalizer::reorderStaticCallArguments($parametersAcceptor, $expr) ?? $expr;
$returnType = $parametersAcceptor->getReturnType();
$isAlwaysTerminating = $returnType instanceof NeverType && $returnType->isExplicit();
$isAlwaysTerminating = $isAlwaysTerminating || ($returnType instanceof NeverType && $returnType->isExplicit());
}
$argsResult = $nodeScopeResolver->processArgs($stmt, $methodReflection, null, $parametersAcceptor, $normalizedExpr, $scope, $storage, $nodeCallback, $context, $closureBindScope);
$scope = $argsResult->getScope();
Expand Down
24 changes: 24 additions & 0 deletions tests/PHPStan/Rules/DeadCode/UnreachableStatementRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,4 +373,28 @@ public function testBug13331(): void
$this->analyse([__DIR__ . '/data/bug-13331.php'], []);
}

#[RequiresPhp('>= 8.2')]
public function testBug14328(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/data/bug-14328.php'], [
[
'Unreachable statement - code above always terminates.',
20,
],
[
'Unreachable statement - code above always terminates.',
26,
],
[
'Unreachable statement - code above always terminates.',
32,
],
[
'Unreachable statement - code above always terminates.',
38,
],
]);
}

}
39 changes: 39 additions & 0 deletions tests/PHPStan/Rules/DeadCode/data/bug-14328.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php // lint >= 8.2

declare(strict_types = 1);

namespace Bug14328;

class Foo {
public function returnThis(mixed $value): self {
return $this;
}

public static function returnSelf(mixed $value): self {
return new self();
}
}

function testMethodCallChainedWithMethodCall(): void {
$callback = fn (): never => throw new \Exception();
$x = (new Foo())->returnThis($callback())->returnThis('x');
$y = 'this will never run';
}

function testMethodCallChainedWithStaticCall(): void {
$callback = fn (): never => throw new \Exception();
$x = (new Foo())->returnThis($callback())::returnSelf('x');
$y = 'this will never run';
}

function testStaticCallChainedWithMethodCall(): void {
$callback = fn (): never => throw new \Exception();
$a = Foo::returnSelf($callback())->returnThis('x');
$b = 'this will never run either';
}

function testStaticCallChainedWithStaticCall(): void {
$callback = fn (): never => throw new \Exception();
$a = Foo::returnSelf($callback())::returnSelf('x');
$b = 'this will never run either';
}
Loading