Skip to content

Add non regression test#5252

Merged
staabm merged 2 commits intophpstan:2.1.xfrom
VincentLanglet:non-regression-test
Mar 19, 2026
Merged

Add non regression test#5252
staabm merged 2 commits intophpstan:2.1.xfrom
VincentLanglet:non-regression-test

Conversation

@VincentLanglet
Copy link
Contributor

Both #5203 and #5189 seems to break the following snippet.

It might be simpler to

  • merge this regression test
  • close the PRs
  • reopen them with the bot

WDYT @staabm ?

@VincentLanglet VincentLanglet requested a review from staabm March 19, 2026 14:19
@staabm
Copy link
Contributor

staabm commented Mar 19, 2026

I had a similar idea. I think we can merge this test.

I would make it smaller though: https://phpstan.org/r/50723b9b-06bc-4d7d-b1e1-5692ca02ca84

(and maybe rebase open PRs instead of starting from square-1 is enough)

@staabm staabm merged commit 889361f into phpstan:2.1.x Mar 19, 2026
377 checks passed
@staabm
Copy link
Contributor

staabm commented Mar 19, 2026

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants