Skip to content

Do not parse PR body to find issues to close #5046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takaram wants to merge 2 commits into from
+12 −10
Closed

Do not parse PR body to find issues to close #5046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ac78c0
Do not parse PR body to find issues to close
takaram Feb 25, 2026
d3cdd83
Fix CI errors
takaram Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/workflows/close-issues-on-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,21 @@ jobs:
- name: "Find and close linked issues"
env:
GH_TOKEN: ${{ secrets.PHPSTAN_BOT_TOKEN }}
GH_REPO: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}
PR_URL: ${{ github.event.pull_request.html_url }}
run: |
PR_BODY=$(gh pr view ${{ github.event.pull_request.number }} --repo "${{ github.repository }}" --json body --jq '.body')
mapfile -t URLS < <(
gh pr view "$PR_NUMBER" --json closingIssuesReferences --jq '.closingIssuesReferences[].url'
)

# Parse "Closes/Fixes https://github.com/phpstan/phpstan/issues/123" patterns
URLS=$(echo "$PR_BODY" | grep -oiP '(?:closes?|fix(?:es)?)\s+https://github\.com/phpstan/phpstan/issues/[0-9]+' | grep -oP 'https://github\.com/phpstan/phpstan/issues/[0-9]+' || true)

if [ -z "$URLS" ]; then
echo "No linked issues found in PR body"
if (( ${#URLS[@]} == 0 )); then
echo "No issues are linked to this PR"
exit 0
fi

echo "$URLS" | while read -r url; do
NUMBER=$(echo "$url" | grep -oP '[0-9]+$')
echo "Closing phpstan/phpstan#${NUMBER}"
gh issue close "$NUMBER" --repo "phpstan/phpstan" --comment "Closed via merging ${{ github.event.pull_request.html_url }}"
for issue_url in "${URLS[@]}"; do
issue_number=${issue_url##*/}
echo "Closing phpstan/phpstan#${issue_number}"
gh issue close "$issue_url" --comment "Closed via merging $PR_URL"
done
Loading