Keep rootExpr for equality assertions, move specifyOnly after rootExpr check

- Revert equality assertions (`@phpstan-assert =`) back to using
  `rootExpr = $call` instead of `specifyOnly`. The rootExpr mechanism
  in ImpossibleCheckTypeHelper provides more nuanced detection (constant
  boolean evaluation via scope) and is the established path for these.
  `specifyOnly` is reserved for the FAUX replacement cases (str_contains,
  array_key_exists) where sureTypes are pure side effects.

- Move the `specifyOnly` check after the `rootExpr` check in
  ImpossibleCheckTypeHelper so that rootExpr takes precedence when both
  flags are set (e.g. via unionWith/intersectWith propagation).

- Add duplicate call test cases (str_ends_with, str_contains) to
  document that nested identical calls are not reported as always-true.
  This was never detected before — the old FAUX mechanism also returned
  null for these — and would require a separate mechanism (tracking
  function call results in scope).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/Analyser/TypeSpecifier.php

@@ -1856,10 +1856,7 @@ static function (Type $type, callable $traverse) use ($templateTypeMap, &$contai
 					$assertedType,
 					$assert->isNegated() ? TypeSpecifierContext::createFalse() : TypeSpecifierContext::createTrue(),
 					$scope,
-				)->setRootExpr($containsUnresolvedTemplate ? $call : null);
-				if ($assert->isEquality()) {
-					$newTypes = $newTypes->setSpecifyOnly();
-				}
+				)->setRootExpr($containsUnresolvedTemplate || $assert->isEquality() ? $call : null);
 				$types = $types !== null ? $types->unionWith($newTypes) : $newTypes;
 
 				if (!$context->null() || !$assertedType instanceof ConstantBooleanType) {

src/Rules/Comparison/ImpossibleCheckTypeHelper.php

@@ -273,10 +273,6 @@ public function findSpecifiedType(
 			return null;
 		}
 
-		if ($specifiedTypes->isSpecifyOnly()) {
-			return null;
-		}
-
 		$sureTypes = $specifiedTypes->getSureTypes();
 		$sureNotTypes = $specifiedTypes->getSureNotTypes();
 
@@ -294,6 +290,10 @@ public function findSpecifiedType(
 			return null;
 		}
 
+		if ($specifiedTypes->isSpecifyOnly()) {
+			return null;
+		}
+
 		$results = [];
 
 		$assignedInCallVars = [];

tests/PHPStan/Rules/Comparison/data/bug-14705.php

@@ -66,4 +66,28 @@ public function arrayKeyExistsNonEmpty(array $array, string $key): void
 		}
 	}
 
+	/**
+	 * @param non-empty-string $needle
+	 */
+	public function strEndsWithDuplicate(string $haystack, string $needle): void
+	{
+		if (str_ends_with($haystack, $needle)) {
+			if (str_ends_with($haystack, $needle)) {
+
+			}
+		}
+	}
+
+	/**
+	 * @param non-empty-string $needle
+	 */
+	public function strContainsDuplicate(string $haystack, string $needle): void
+	{
+		if (str_contains($haystack, $needle)) {
+			if (str_contains($haystack, $needle)) {
+
+			}
+		}
+	}
+
 }