Rename shouldNotDetermineCheckResult to specifyOnly

The flag means "these SpecifiedTypes only narrow types, don't use them
to determine check outcome" — `specifyOnly` captures this concisely
using the domain language of the SpecifiedTypes class.

`overwrite` remains independent: it controls how types are applied in
MutatingScope (assign vs intersect), while `specifyOnly` controls
ImpossibleCheckTypeHelper. They already have separate early-return
checks and serve different purposes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/Analyser/SpecifiedTypes.php

@@ -13,7 +13,7 @@ final class SpecifiedTypes
 
 	private bool $overwrite = false;
 
-	private bool $shouldNotDetermineCheckResult = false;
+	private bool $specifyOnly = false;
 
 	/** @var array<string, ConditionalExpressionHolder[]> */
 	private array $newConditionalExpressionHolders = [];
@@ -53,29 +53,28 @@ public function setAlwaysOverwriteTypes(): self
 	{
 		$self = new self($this->sureTypes, $this->sureNotTypes);
 		$self->overwrite = true;
-		$self->shouldNotDetermineCheckResult = $this->shouldNotDetermineCheckResult;
+		$self->specifyOnly = $this->specifyOnly;
 		$self->newConditionalExpressionHolders = $this->newConditionalExpressionHolders;
 		$self->rootExpr = $this->rootExpr;
 
 		return $self;
 	}
 
 	/**
-	 * Normally, when a type-specifying extension returns SpecifiedTypes with sureTypes,
-	 * ImpossibleCheckTypeHelper will analyze whether those types are already satisfied
-	 * and conclude the check is always-true/always-false.
+	 * When set, the sureTypes are only used for narrowing — ImpossibleCheckTypeHelper
+	 * will not use them to determine whether the check is always-true/always-false.
 	 *
-	 * When this flag is set, that analysis is skipped. Use this when the sureTypes
-	 * are a side effect of the check (e.g. str_contains narrowing haystack to non-empty-string)
+	 * Use this when the sureTypes are a side effect of the check
+	 * (e.g. str_contains narrowing haystack to non-empty-string)
 	 * rather than the determining condition.
 	 *
 	 * @api
 	 */
-	public function setShouldNotDetermineCheckResult(): self
+	public function setSpecifyOnly(): self
 	{
 		$self = new self($this->sureTypes, $this->sureNotTypes);
 		$self->overwrite = $this->overwrite;
-		$self->shouldNotDetermineCheckResult = true;
+		$self->specifyOnly = true;
 		$self->newConditionalExpressionHolders = $this->newConditionalExpressionHolders;
 		$self->rootExpr = $this->rootExpr;
 
@@ -89,7 +88,7 @@ public function setRootExpr(?Expr $rootExpr): self
 	{
 		$self = new self($this->sureTypes, $this->sureNotTypes);
 		$self->overwrite = $this->overwrite;
-		$self->shouldNotDetermineCheckResult = $this->shouldNotDetermineCheckResult;
+		$self->specifyOnly = $this->specifyOnly;
 		$self->newConditionalExpressionHolders = $this->newConditionalExpressionHolders;
 		$self->rootExpr = $rootExpr;
 
@@ -103,7 +102,7 @@ public function setNewConditionalExpressionHolders(array $newConditionalExpressi
 	{
 		$self = new self($this->sureTypes, $this->sureNotTypes);
 		$self->overwrite = $this->overwrite;
-		$self->shouldNotDetermineCheckResult = $this->shouldNotDetermineCheckResult;
+		$self->specifyOnly = $this->specifyOnly;
 		$self->newConditionalExpressionHolders = $newConditionalExpressionHolders;
 		$self->rootExpr = $this->rootExpr;
 
@@ -133,9 +132,9 @@ public function shouldOverwrite(): bool
 		return $this->overwrite;
 	}
 
-	public function shouldNotDetermineCheckResult(): bool
+	public function isSpecifyOnly(): bool
 	{
-		return $this->shouldNotDetermineCheckResult;
+		return $this->specifyOnly;
 	}
 
 	/**
@@ -160,7 +159,7 @@ public function removeExpr(string $exprString): self
 
 		$self = new self($sureTypes, $sureNotTypes);
 		$self->overwrite = $this->overwrite;
-		$self->shouldNotDetermineCheckResult = $this->shouldNotDetermineCheckResult;
+		$self->specifyOnly = $this->specifyOnly;
 		$self->newConditionalExpressionHolders = $this->newConditionalExpressionHolders;
 		$self->rootExpr = $this->rootExpr;
 
@@ -200,8 +199,8 @@ public function intersectWith(SpecifiedTypes $other): self
 		if ($this->overwrite && $other->overwrite) {
 			$result = $result->setAlwaysOverwriteTypes();
 		}
-		if ($this->shouldNotDetermineCheckResult || $other->shouldNotDetermineCheckResult) {
-			$result = $result->setShouldNotDetermineCheckResult();
+		if ($this->specifyOnly || $other->specifyOnly) {
+			$result = $result->setSpecifyOnly();
 		}
 
 		return $result->setRootExpr($rootExpr);
@@ -240,8 +239,8 @@ public function unionWith(SpecifiedTypes $other): self
 		if ($this->overwrite || $other->overwrite) {
 			$result = $result->setAlwaysOverwriteTypes();
 		}
-		if ($this->shouldNotDetermineCheckResult || $other->shouldNotDetermineCheckResult) {
-			$result = $result->setShouldNotDetermineCheckResult();
+		if ($this->specifyOnly || $other->specifyOnly) {
+			$result = $result->setSpecifyOnly();
 		}
 
 		$conditionalExpressionHolders = $this->newConditionalExpressionHolders;
@@ -274,8 +273,8 @@ public function normalize(Scope $scope): self
 		if ($this->overwrite) {
 			$result = $result->setAlwaysOverwriteTypes();
 		}
-		if ($this->shouldNotDetermineCheckResult) {
-			$result = $result->setShouldNotDetermineCheckResult();
+		if ($this->specifyOnly) {
+			$result = $result->setSpecifyOnly();
 		}
 
 		return $result->setRootExpr($this->rootExpr);

src/Analyser/TypeSpecifier.php

@@ -1858,7 +1858,7 @@ static function (Type $type, callable $traverse) use ($templateTypeMap, &$contai
 					$scope,
 				)->setRootExpr($containsUnresolvedTemplate ? $call : null);
 				if ($assert->isEquality()) {
-					$newTypes = $newTypes->setShouldNotDetermineCheckResult();
+					$newTypes = $newTypes->setSpecifyOnly();
 				}
 				$types = $types !== null ? $types->unionWith($newTypes) : $newTypes;
 

src/Rules/Comparison/ImpossibleCheckTypeHelper.php

@@ -273,10 +273,7 @@ public function findSpecifiedType(
 			return null;
 		}
 
-		// sureTypes are side effects of the check (e.g. str_contains narrowing
-		// haystack to non-empty-string), not the determining condition — they
-		// can't tell us whether the check is always-true or always-false.
-		if ($specifiedTypes->shouldNotDetermineCheckResult()) {
+		if ($specifiedTypes->isSpecifyOnly()) {
 			return null;
 		}
 

src/Type/Php/ArrayKeyExistsFunctionTypeSpecifyingExtension.php

@@ -112,7 +112,7 @@ public function specifyTypes(
 					$arrayType->getIterableValueType(),
 					$context,
 					$scope,
-				))->setShouldNotDetermineCheckResult();
+				))->setSpecifyOnly();
 			}
 
 			return new SpecifiedTypes();

src/Type/Php/StrContainingTypeSpecifyingExtension.php

@@ -84,7 +84,7 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 					new IntersectionType($accessories),
 					$context,
 					$scope,
-				)->setShouldNotDetermineCheckResult();
+				)->setSpecifyOnly();
 			}
 		}