Skip to content

fixed 'Method ReflectionProperty::setAccessible() is deprecated since 8.5' #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrafrost merged 4 commits into from
Apr 8, 2026
Merged

fixed 'Method ReflectionProperty::setAccessible() is deprecated since 8.5' #45

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5754587
fixed PH8.5 deprecation warning
shimooka Apr 2, 2026
28341b9
fixed checking php version
shimooka Apr 3, 2026
46801db
fixed typo
shimooka Apr 3, 2026
56b8f42
fixed typo
shimooka Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/mcrypt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,11 @@ function phpseclib_mcrypt_generic_deinit(Base &$td)
{
$reflectionObject = new \ReflectionObject($td);
$reflectionProperty = $reflectionObject->getProperty('key');
$reflectionProperty->setAccessible(true); // can be dropped in PHP 8.1.0+

if (version_compare(phpversion(), '8.1.0', '<')) {
Copy link
Copy Markdown
Member

@terrafrost terrafrost Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that's technically valid, could you replace that with this?:

PHP_VERSION_ID < 80100

It's more consistent with how phpseclib v3 does things and it's marginally faster as well.

Thanks!

$reflectionProperty->setAccessible(true); // can be dropped in PHP 8.1.0+
Copy link
Copy Markdown
Member

@terrafrost terrafrost Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need that comment anymore now that we have that if statement!

}

if (!strlen($reflectionProperty->getValue($td))) {
trigger_error('mcrypt_generic_deinit(): Could not terminate encryption specifier', E_USER_WARNING);
return false;
Expand Down