Skip to content

Fix merge #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMattPro merged 1 commit into from
Aug 12, 2026
Merged

Fix merge #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ jobs:
run: |
Enable-WindowsOptionalFeature -Online -FeatureName IIS-WebServerRole, IIS-WebServer, IIS-CommonHttpFeatures, IIS-ManagementConsole, IIS-HttpErrors, IIS-HttpRedirect, IIS-WindowsAuthentication, IIS-StaticContent, IIS-DefaultDocument, IIS-HttpCompressionStatic, IIS-DirectoryBrowsing, IIS-WebServerManagementTools, IIS-CGI -All
Set-Service wuauserv -StartupType Manual
$webConfig = "${env:GITHUB_WORKSPACE}\phpBB3\phpBB\web.config"
$webConfig = "${env:GITHUB_WORKSPACE}\phpBB4\phpBB\web.config"
$content = Get-Content $webConfig -Raw
$content = $content.Replace(
"<configuration>",
Expand All @@ -733,9 +733,13 @@ jobs:
$rewriteInstalled = $false
try {
choco install urlrewrite -y --no-progress
$rewriteInstalled = $true
if ($LASTEXITCODE -eq 0) {
$rewriteInstalled = $true
} else {
Write-Warning "URL Rewrite installation failed with exit code $LASTEXITCODE; continuing without rewrite-specific IIS configuration."
}
} catch {
Write-Warning "URL Rewrite installation failed; continuing without rewrite-specific IIS configuration."
Write-Warning "URL Rewrite installation failed: $($_.Exception.Message); continuing without rewrite-specific IIS configuration."
}
if (-not $rewriteInstalled) {
$content = $content -replace "(?s)`r?`n\s*<rewrite>.*?</rewrite>", ""
Expand Down