Skip to content

Fix windows again #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMattPro merged 1 commit into from
Aug 12, 2026
Merged

Fix windows again #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,22 +697,6 @@ jobs:
Enable-WindowsOptionalFeature -Online -FeatureName IIS-WebServerRole, IIS-WebServer, IIS-CommonHttpFeatures, IIS-ManagementConsole, IIS-HttpErrors, IIS-HttpRedirect, IIS-WindowsAuthentication, IIS-StaticContent, IIS-DefaultDocument, IIS-HttpCompressionStatic, IIS-DirectoryBrowsing, IIS-WebServerManagementTools, IIS-CGI -All
Set-Service wuauserv -StartupType Manual
$webConfig = "${env:GITHUB_WORKSPACE}\phpBB3\phpBB\web.config"
# Install URL Rewrite with retries because Chocolatey feed requests can timeout on GitHub runners.
$installed = $false
for ($i = 1; $i -le 3; $i++) {
try {
choco install urlrewrite -y --no-progress
$installed = $true
break
} catch {
Write-Warning "URL Rewrite install attempt $i failed: $($_.Exception.Message)"
Start-Sleep -Seconds (10 * $i)
}
}
if (-not $installed) {
throw "Failed to install URL Rewrite after 3 attempts."
}
# Only patch web.config after rewrite is installed.
$content = Get-Content $webConfig -Raw
$content = $content.Replace(
"<configuration>",
Expand All @@ -722,6 +706,16 @@ jobs:
"`t</system.webServer>",
"`t`t<httpErrors errorMode=`"Detailed`" />`n`t</system.webServer>"
)
$rewriteInstalled = $false
try {
choco install urlrewrite -y --no-progress
$rewriteInstalled = $true
} catch {
Write-Warning "URL Rewrite installation failed; continuing without rewrite-specific IIS configuration."
}
if (-not $rewriteInstalled) {
$content = $content -replace "(?s)`r?`n\s*<rewrite>.*?</rewrite>", ""
}
Set-Content $webConfig -Value $content -Encoding UTF8
Import-Module WebAdministration
New-WebSite -Name 'phpBBTest' -PhysicalPath "${env:GITHUB_WORKSPACE}\phpBB3\phpBB" -Force
Expand Down