Future proof issues going into phpBB4

[iMattPro]

This should make the fatal issues Pages has when running in phpBB4. Of course there will be a proper non-backwards-compatible version of Pages after phpBB4 is eventually released. But these changes are intended to keep the current release of Pages working in both phpBB 3.3.x and 4 w/o generating fatal errors. These changes (at least for the text reparser cron task) may be removed/omitted from the non-backwards-compatible version of Pages that will be for phpBB 4 or greater.

Fatal issues when Pages is run under phpBB4:

1. Using dispatcher->dispatch no longer works
2. The parameters for the text-reparser cron task are different (dropped config_text)

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.20%. Comparing base (421c561) to head (c604e81).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
controller/admin_controller.php	0.00%	1 Missing ⚠️
textreparser/cron_text_reparser_factory.php	95.45%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     59.19%   60.20%   +1.01%     
- Complexity      208      214       +6     
============================================
  Files            14       15       +1     
  Lines           767      789      +22     
============================================
+ Hits            454      475      +21     
- Misses          313      314       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rxu]

It still won't work on 4.0 because of is_enableable() restricts phpBB version to <4.0.0-dev.
Edited it locally and it seems to successfully installs and works on 4.0.0-dev, including cron task.
The ext also works on 3.3 but the cron task never runs for some reason (updated from previous Pages version), probably just because there's nothing to reparse.

[iMattPro]

It still won't work on 4.0 because of is_enableable() restricts phpBB version to <4.0.0-dev. Edited it locally and it seems to successfully installs and works on 4.0.0-dev, including cron task. The ext also works on 3.3 but the cron task never runs for some reason (updated from previous Pages version), probably just because there's nothing to reparse.

That's correct, this should not be allowed to be installed on 4.0. This PR is trying to handle the situation when a 3.3.x board with Pages already installed, upgrades to phpBB 4 while Pages is still enabled/active.

Yes if the reparser has gone through pages once, it won't again (unless new Pages are added I guess?)