Update ConstructorPromotionTest.php#645
Update ConstructorPromotionTest.php#645Hamad-Rashid wants to merge 1 commit intophpDocumentor:6.xfrom
Conversation
the optional parameter $email is declared before a required parameter $birth_date, which is not allowed in PHP 8. In PHP, optional parameters must always come after the required parameters.
|
the optional parameter $email is declared before a required parameter $birth_date, which is not allowed in PHP 8. In PHP, optional parameters must always come after the required parameters. |
jaapio
left a comment
There was a problem hiding this comment.
Looks like some tests are failing. Can you have a look at those
This is not correct, it became valid in PHP 8.0 because of named parameters. Only in 7.4 and older was this invalid. Considering that the project requires PHP 8.1 there shouldn't be a need for this change. |
|
This pr hasn't had any updates since my first comment. I will close this. |
the optional parameter $email is declared before a required parameter $birth_date, which is not allowed in PHP 8. In PHP, optional parameters must always come after the required parameters.