Skip to content

Update path constants to public folder - #1987

Merged
svpernova09 merged 3 commits into
php:masterfrom
svpernova09:fix-archive-path
Aug 13, 2026
Merged

Update path constants to public folder#1987
svpernova09 merged 3 commits into
php:masterfrom
svpernova09:fix-archive-path

Conversation

@svpernova09

@svpernova09 svpernova09 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Ran into this issue this morning trying to create an announcement.

┌─(~/Code/php/web-php)(master M:1 S:8)
└─(141)─ ./bin/createNewsEntry
Can't find archive/archive.xml, are you sure you are in phpweb/?

┌─(~/Code/php/web-php)(master M:1 S:8)
└─(1)─ ll
total 584
drwxr-xr-x@  7 halo  staff     224 Aug 10 07:45 bin/
-rw-r--r--@  1 halo  staff     936 Aug 10 07:45 composer.json
-rw-r--r--@  1 halo  staff  168217 Aug 10 07:45 composer.lock
drwxr-xr-x@ 33 halo  staff    1056 Aug 13 09:15 include/
-rw-r--r--@  1 halo  staff    1516 Jul 30 09:05 Makefile
-rw-r--r--@  1 halo  staff    8208 Apr 16 10:58 openapi.yml
-rw-r--r--@  1 halo  staff     135 Apr 16 10:58 package.json
-rw-r--r--@  1 halo  staff   83745 Aug 10 07:45 phpstan-baseline.neon
-rw-r--r--@  1 halo  staff     306 Aug 10 07:45 phpstan.neon.dist
-rw-r--r--@  1 halo  staff    1256 Jul  7 15:56 playwright.config.ts
drwxr-xr-x@ 75 halo  staff    2400 Aug 10 07:45 public/
-rw-r--r--@  1 halo  staff    1085 Aug 10 07:45 README.md
drwxr-xr-x@ 11 halo  staff     352 Aug 10 07:45 src/
drwxr-xr-x@  7 halo  staff     224 Aug 10 07:45 tests/
drwxr-xr-x@ 21 halo  staff     672 Jul 23 21:06 vendor/
-rw-r--r--@  1 halo  staff    1875 Apr 16 10:58 yarn.lock

┌─(~/Code/php/web-php)(master M:1 S:8)
└─(130)─ find . -name archive
./public/archive

Also ran into this:

┌─(~/Code/php/web-php)(master M:1 S:8)
└─(1)─ ./bin/createNewsEntry
Please type in the title: PHP 8.6.0beta1 is available for testing
Categories:
	0: PHP.net frontpage news	 [frontpage]
	1: New PHP release	 [releases]
	2: Conference announcement	 [conferences]
	3: Call for Papers	 [cfp]
Please select appropriate categories, seperated with space: 0
Will a picture be accompanying this entry?(y/N) N
PHP Fatal error:  Uncaught Exception: Image not found at web-php/images/news/ in /Users/halo/Code/php/web-php/src/News/Entry.php:81
Stack trace:
#0 /Users/halo/Code/php/web-php/bin/createNewsEntry(44): phpweb\News\Entry->setImage('', '', '')
#1 /Users/halo/Code/php/web-php/bin/createNewsEntry(25): getEntry()
#2 {main}
  thrown in /Users/halo/Code/php/web-php/src/News/Entry.php on line 81

Fatal error: Uncaught Exception: Image not found at web-php/images/news/ in /Users/halo/Code/php/web-php/src/News/Entry.php:81
Stack trace:
#0 /Users/halo/Code/php/web-php/bin/createNewsEntry(44): phpweb\News\Entry->setImage('', '', '')
#1 /Users/halo/Code/php/web-php/bin/createNewsEntry(25): getEntry()
#2 {main}
  thrown in /Users/halo/Code/php/web-php/src/News/Entry.php on line 81
./bin/createNewsEntry: 00:45

@svpernova09 svpernova09 changed the title Update ARCHIVE_FILE_REL to public folder Update ARCHIVE_FILE_REL & IMAGE_PATH_REL to public folder Aug 13, 2026
Comment thread src/News/Entry.php Outdated
@svpernova09 svpernova09 changed the title Update ARCHIVE_FILE_REL & IMAGE_PATH_REL to public folder Update path constants to public folder Aug 13, 2026

@DanielEScherzer DanielEScherzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, test failures appear unrelated and preexisting

@svpernova09
svpernova09 merged commit e41194c into php:master Aug 13, 2026
1 of 4 checks passed
@svpernova09
svpernova09 deleted the fix-archive-path branch August 13, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants