Allow all scalar types in ini_set()#6680
Closed
nikic wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@kocsismate @Girgias @cmb69 Any thoughts on this? This is partially motivated by #6475, which will bring the null case to strict_types=0 as well. |
Member
|
Makes sense to me. |
Member
|
Yes, I also find it a reasonable change. |
Girgias
approved these changes
Feb 11, 2021
| var_dump(ini_get('html_errors')); | ||
| ini_set('precision', 6); | ||
| var_dump(ini_get('precision')); | ||
| // Are there any float options? |
Member
There was a problem hiding this comment.
"opcache.jit_prof_threshold" and "session.upload_progress.min_freq" seem to be the only ones looking at https://heap.space/s?refs=OnUpdateReal&project=php-src
Member
Author
There was a problem hiding this comment.
Heh, I search for OnUpdateDouble and OnUpdatFloat ... didn't expect it to be called OnUpdateReal!
Member
Author
There was a problem hiding this comment.
Both are part of optional exts and session.upload_progress.min_freq is PERDIR :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
ini_set()to accept all scalar types (string|int|float|bool|null) for the new value. The idea here is that while the INI system ultimately works with strings, its value interpretation is designed to be consistent with PHP's casting rules, e.g."1"and""are interpreted as boolean true and false respectively.I personally believe that writing
ini_set('precision', 10)makes more sense thanini_set('precision', '10'), and findstrict_typesto be unnecessarily pedantic here.