Refactor levenshtein()#5816
Closed
Girgias wants to merge 2 commits into
Closed
Conversation
Girgias
force-pushed
the
refactor-levenstein
branch
from
89451da to
f359601
Compare
cmb69
reviewed
Jul 6, 2020
cmb69
left a comment
cmb69
left a comment
Member
There was a problem hiding this comment.
Thanks! Very welcome clean-up. :)
Member
There was a problem hiding this comment.
Suggested change
| zend_argument_value_error(1, "must be less than %d characters", LEVENSHTEIN_MAX_LENGTH); | |
| zend_argument_value_error(1, "must be less than %d characters", LEVENSHTEIN_MAX_LENGTH + 1); |
or
Suggested change
| zend_argument_value_error(1, "must be less than %d characters", LEVENSHTEIN_MAX_LENGTH); | |
| zend_argument_value_error(1, "must be less than or equal to %d characters", LEVENSHTEIN_MAX_LENGTH); |
(same below)
Girgias
force-pushed
the
refactor-levenstein
branch
from
f359601 to
c00e0fa
Compare
nikic
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unimplemented overloaded variant about using a callable for the 3rd argument (which only takes a string callable as this code is OLD) is removed and should if implemented be implemented as a separate function (see: https://bugs.php.net/bug.php?id=34835)
This should also fix: https://bugs.php.net/bug.php?id=79050
I'm not sure if the length limitation makes much sense in 2020.
Also I wonder if I should classify as a ValueError negative costs (<= 0)