Add zend_call_known_function() API family#5692
Closed
nikic wants to merge 2 commits into
Closed
Conversation
Member
|
nice, it looks good to me |
Member
|
Shouldn't the |
Member
Author
Done! |
Member
Shouldn't the |
Member
Author
|
@twose I've adjusted the zend_call_method type while merging. I've also replaced a few more cases where the new function is useful, found by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the following APIs:
These are used to perform a call if you already have the
zend_functionyou want to call.zend_call_known_function()is the base API, the rest are just really thin wrappers around it for the common case of instance method calls.cc @twose This splits out the part of the zend_call_method functionality that does not require a method name at all.
cc @morrisonlevi I believe you asked me about this at some point.