Make Exception::$trace typed array property#5636
Closed
nikic wants to merge 1 commit into
Closed
Conversation
nikic
force-pushed
the
exception-trace-type
branch
from
fb8993c to
1a51ba2
Compare
carusogabriel
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a private property, so we are allowed to add a type. The new declaration of the property is
This ensures that
Exception::getTrace()does indeed return an array.Userland code that was removing the trace by assigning null via reflection needs to be updated to assign
[]instead.