W.I.P. Zend: Add new Z_PARAM_DERIVED_CLASS_NAME Fast ZPP specifier - #23452
Draft
Girgias wants to merge 7 commits into
Draft
W.I.P. Zend: Add new Z_PARAM_DERIVED_CLASS_NAME Fast ZPP specifier#23452Girgias wants to merge 7 commits into
Girgias wants to merge 7 commits into
Conversation
Remove old specifiers, add new ones, accept unsigned char** for 's' and 'p'. Some code modernization. Still produces some errors but those require actual fixes or parsing improvements
Splitting the logic of Z_PARAM_CLASS with an assigned pointer actually obvious
Convert to new Fast ZPP specifier
Girgias
force-pushed
the
2026-08-zpp-class-name-derived-from-ce
branch
from
August 25, 2026 14:22
d2bdb8f to
92a1a23
Compare
ndossche
reviewed
Aug 25, 2026
| foreach ($exp as $expected_type) { | ||
| $str .= "'$expected_type' or "; | ||
| } | ||
| rtrim($str, 'or '); |
Member
There was a problem hiding this comment.
2 classic mistakes: rtrim does return a new string, and also, the 'or ' will be interpreted as strip ' ' and 'r' and 'o'.
Member
Author
There was a problem hiding this comment.
duh, yes. Being a bit tired and was trying to get this to not emit warnings. So I didn't check that it emits a sensible warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.