Skip to content

More curl tests - #23333

Open
Sjord wants to merge 17 commits into
php:masterfrom
Sjord:more-curl-tests
Open

More curl tests#23333
Sjord wants to merge 17 commits into
php:masterfrom
Sjord:more-curl-tests

Conversation

@Sjord

@Sjord Sjord commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Sjord
Sjord marked this pull request as ready for review August 18, 2026 08:38
@Sjord
Sjord requested a review from adoy as a code owner August 18, 2026 08:38
@Sjord

Sjord commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

@NickSdot Could you take a look at this?

@NickSdot NickSdot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot really judge in detail what's tested, but found some things worth pointing out. Also, can confirm that this closes coverage gaps. ✌️

Coverage: ext/curl

Base: c621cbe27ffe59ed98228724d674dcadcf7f6e8d upstream/master
Tree: 2aa80efcacc776c87712a9beed9487c40be6cffc working tree

+--------+-------+---------+--------------------+-------------------+--------+---------+
|        | Tests | Sources |              Lines |          Branches |   Time |  Memory |
+--------+-------+---------+--------------------+-------------------+--------+---------+
| Base   |   189 |       6 | 2520/2912 (86.54%) | 847/4640 (18.25%) | 64.23s | 45.5 MB |
| Tree   |   197 |       6 | 2538/2912 (87.16%) | 857/4640 (18.47%) | 68.17s | 45.1 MB |
| Change |    +8 |       0 |  +18 / -0 (+0.62%) | +10 / -0 (+0.22%) | +3.94s | -0.4 MB |
+--------+-------+---------+--------------------+-------------------+--------+---------+

Comment thread ext/curl/tests/curl_getinfo_CURLINFO_HEADER_OUT.phpt Outdated
Comment thread ext/curl/tests/curl_setopt_CURLOPT_POSTREDIR.phpt Outdated
Comment thread ext/curl/tests/curl_setopt_CURLOPT_SSH_HOSTKEYFUNCTION.phpt
Comment thread ext/curl/tests/curl_setopt_CURLOPT_MAXFILESIZE_LARGE.phpt
Comment thread ext/curl/tests/curl_setopt_CURLOPT_WRITEHEADER.phpt Outdated
Comment thread ext/curl/tests/curl_setopt_CURLOPT_WRITEHEADER.phpt Outdated
Comment thread ext/curl/tests/curl_setopt_CURLOPT_FNMATCH_FUNCTION.phpt Outdated
Sjord added 2 commits August 24, 2026 14:14
It has the option, but it works differently.

We could make it work on earlier versions by including a Content-Type
header, but I don't really see the use of that. The goal of the test is
to see whether curl_off_t are correctly passed off to curl, not the
behavior of curl itself.
@Sjord
Sjord requested a review from NickSdot August 24, 2026 15:59
@Sjord

Sjord commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@LamentXU123 Could you take a look at this?

@LamentXU123

Copy link
Copy Markdown
Member

Sorry, I am not familiar with curl API. Maybe @devnexen can help here.

Comment thread ext/curl/tests/curl_setopt_CURLOPT_SSH_HOSTKEYFUNCTION.phpt Outdated
Comment thread ext/curl/tests/curl_setopt_CURLOPT_FNMATCH_FUNCTION.phpt Outdated
Sjord added 2 commits August 25, 2026 09:01
They are pretty verbose and don't add much
@Sjord Sjord closed this Aug 25, 2026
@Sjord Sjord reopened this Aug 25, 2026
@Sjord

Sjord commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Windows test fails with:

NMAKE : fatal error U1077: '  "C:\obj\Release_TS\php.exe" -d open_basedir= -d output_buffering=0 run-tests.php -d opcache.enable=1 -d opcache.enable_cli=1 -d opcache.protect_memory=1 -d opcache.jit_buffer_size=64M -d opcache.jit=tracing -g FAIL,BORK,LEAK,XLEAK  --no-progress -q --offline --show-diff --show-slow 1000 --set-timeout 120 --temp-source c:\tests_tmp --temp-target c:\tests_tmp  -p "C:\obj\Release_TS\php.exe"' : return code '0x1'
Stop.

Microsoft (R) Program Maintenance Utility Version 14.51.36256.0
Copyright (C) Microsoft Corporation.  All rights reserved.

SUCCESS: The process "snmpd.exe" with PID 7740 has been terminated.

D:\a\php-src\php-src>if 2 NEQ 0 exit /b 3 
Error: Process completed with exit code 1.

This doesn't seem related to this PR, but I am not sure what is going on.

@Sjord
Sjord requested a review from devnexen August 25, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants