More curl tests - #23333
Open
Sjord wants to merge 17 commits into
Open
Conversation
Allow setting target of redirect in test
Sjord
marked this pull request as ready for review
August 18, 2026 08:38
Contributor
Author
|
@NickSdot Could you take a look at this? |
NickSdot
reviewed
Aug 18, 2026
NickSdot
left a comment
Contributor
There was a problem hiding this comment.
Cannot really judge in detail what's tested, but found some things worth pointing out. Also, can confirm that this closes coverage gaps. ✌️
Coverage: ext/curl
Base: c621cbe27ffe59ed98228724d674dcadcf7f6e8d upstream/master
Tree: 2aa80efcacc776c87712a9beed9487c40be6cffc working tree
+--------+-------+---------+--------------------+-------------------+--------+---------+
| | Tests | Sources | Lines | Branches | Time | Memory |
+--------+-------+---------+--------------------+-------------------+--------+---------+
| Base | 189 | 6 | 2520/2912 (86.54%) | 847/4640 (18.25%) | 64.23s | 45.5 MB |
| Tree | 197 | 6 | 2538/2912 (87.16%) | 857/4640 (18.47%) | 68.17s | 45.1 MB |
| Change | +8 | 0 | +18 / -0 (+0.62%) | +10 / -0 (+0.22%) | +3.94s | -0.4 MB |
+--------+-------+---------+--------------------+-------------------+--------+---------+
NickSdot
reviewed
Aug 18, 2026
It has the option, but it works differently. We could make it work on earlier versions by including a Content-Type header, but I don't really see the use of that. The goal of the test is to see whether curl_off_t are correctly passed off to curl, not the behavior of curl itself.
Contributor
Author
|
@LamentXU123 Could you take a look at this? |
Member
|
Sorry, I am not familiar with curl API. Maybe @devnexen can help here. |
devnexen
reviewed
Aug 24, 2026
They are pretty verbose and don't add much
Contributor
Author
|
Windows test fails with: This doesn't seem related to this PR, but I am not sure what is going on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.