ext/uri: Fix static build on Windows by defining LEXBOR_STATIC#22165
Open
luthermonson wants to merge 1 commit into
Open
ext/uri: Fix static build on Windows by defining LEXBOR_STATIC#22165luthermonson wants to merge 1 commit into
luthermonson wants to merge 1 commit into
Conversation
luthermonson
changed the title
Member
|
I know nothing about Windows. Should / Must this be fixed in ext/lexbor instead? |
luthermonson
force-pushed
the
fix/uri-lexbor-static-windows
branch
from
dad77e8 to
da128c4
Compare
Author
|
I think your instinct is correct, i"m running a test right now with a change to lexbor and will report back |
Author
|
@TimWolla thanks for the insight , the change now in lexbor had the same results as doing the define in config.w32 and i was able to get clean static builds on all platforms. |
TimWolla
reviewed
May 28, 2026
PHP bundles lexbor as a static-only extension (ext/lexbor/config.w32
declares EXTENSION("lexbor", ..., false /* never shared */)). On
Windows, ext/lexbor/lexbor/core/def.h defaults LXB_API to
__declspec(dllimport) when LEXBOR_STATIC is not defined, which causes
LNK2019 unresolved external symbol errors for every lxb_* function
referenced from consumers (ext/uri today, potentially others later)
when PHP itself is linked statically without a runtime DLL.
Add AC_DEFINE("LEXBOR_STATIC", 1, ...) in ext/lexbor/config.w32 so
the symbol is placed in main/config.w.h and seen by every PHP source
file that includes php.h before lexbor headers. This covers ext/uri
and any future consumer with one definition, in the right place for
configuration intent.
This change lives entirely in PHP-owned configuration (no modification
to the vendored ext/lexbor/lexbor/ tree), so it survives lexbor library
upgrades without re-application.
luthermonson
force-pushed
the
fix/uri-lexbor-static-windows
branch
from
da128c4 to
5521f86
Compare
TimWolla
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/uriis always built statically and pulls in the bundled lexbor headers via/I ext/lexbor. On Windows, lexbor'sLXB_APImacro defaults to__declspec(dllimport)whenLEXBOR_STATICisn't defined. As a result, when PHP itself is linked statically (no DLL) on Windows, everylxb_*symbol referenced fromext/urifails to resolve: