ext/snmp: rename argument number variables#21723
Merged
Girgias merged 3 commits intophp:masterfrom Apr 13, 2026
Merged
Conversation
Girgias
requested changes
Apr 13, 2026
Girgias
reviewed
Apr 13, 2026
Girgias
approved these changes
Apr 13, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Will let CI run and then merge :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a readability-only follow-up to #21319.
It renames the internal argument-number variables added for error reporting so they describe what they represent more clearly, and replaces the inline
SNMP::setSecurity()comment with named locals at the call site.No behavior changes are intended.
Testing:
git diff --check