Skip to content

Fix proc_close() signal exit code handling #21293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alies-dev wants to merge 3 commits into
base: master
Choose a base branch
from
+50 −4
Open

Fix proc_close() signal exit code handling #21293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a22d029
Fix proc_close() to return 128+signal when child is killed by signal
alies-dev Feb 25, 2026
53b8c64
Fix test: use SIGKILL via /bin/sh instead of posix_kill
alies-dev Feb 25, 2026
bd731e7
Add missing trailing newline in test file
alies-dev Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ext/standard/proc_open.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,13 @@ static void proc_open_rsrc_dtor(zend_resource *rsrc)

if (wait_pid <= 0) {
FG(pclose_ret) = -1;
} else if (WIFEXITED(wstatus)) {
FG(pclose_ret) = WEXITSTATUS(wstatus);
} else if (WIFSIGNALED(wstatus)) {
/* Follow the bash/shell convention: 128 + signal number */
FG(pclose_ret) = 128 + WTERMSIG(wstatus);
} else {
if (WIFEXITED(wstatus)) {
wstatus = WEXITSTATUS(wstatus);
}
FG(pclose_ret) = wstatus;
FG(pclose_ret) = -1;
}

#else
Expand Down
44 changes: 44 additions & 0 deletions ext/standard/tests/general_functions/proc_close_signal_exit_code.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
--TEST--
proc_close() returns 128+signal when child is killed by a signal
--SKIPIF--
<?php
if (PHP_OS_FAMILY === 'Windows') die('skip Not for Windows');
if (!is_executable('/bin/sh')) die('skip /bin/sh not available');
?>
--FILE--
<?php

// Shell that kills itself with SIGKILL (9) — cannot be caught
$process = proc_open(
['/bin/sh', '-c', 'kill -9 $$'],
[['pipe', 'r'], ['pipe', 'w'], ['pipe', 'w']],
$pipes
);

foreach ($pipes as $pipe) {
fclose($pipe);
}

$exitCode = proc_close($process);
// Should be 128 + 9 = 137
var_dump($exitCode);

// Child that exits normally with code 42
$process2 = proc_open(
['/bin/sh', '-c', 'exit 42'],
[['pipe', 'r'], ['pipe', 'w'], ['pipe', 'w']],
$pipes2
);

foreach ($pipes2 as $pipe) {
fclose($pipe);
}

$exitCode2 = proc_close($process2);
// Should be 42
var_dump($exitCode2);

?>
--EXPECT--
int(137)
int(42)
Loading