Skip to content

ext/standard: Throw ValueError for empty paths in copy() #21214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arshidkv12 wants to merge 5 commits into from
+40 −4
Closed

ext/standard: Throw ValueError for empty paths in copy() #21214

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0190b9e
ext/standard: Throw ValueError for empty paths in copy()
arshidkv12 Feb 13, 2026
e63dc47
ext/standard: Throw ValueError for empty paths in copy()
arshidkv12 Feb 13, 2026
25d8666
ext/standard: Throw ValueError for empty paths in copy()
arshidkv12 Feb 15, 2026
2c2cae2
ext/standard: Throw ValueError for empty paths in copy()
arshidkv12 Feb 15, 2026
2fad5ed
ext/standard: Throw ValueError for empty paths in copy()
arshidkv12 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ext/standard/file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1439,13 +1439,18 @@ PHPAPI zend_result php_copy_file_ex(const char *src, const char *dest, int src_f
/* }}} */

/* {{{ php_copy_file_ctx */
PHPAPI zend_result php_copy_file_ctx(const char *src, const char *dest, int src_flags, php_stream_context *ctx)
ZEND_ATTRIBUTE_NONNULL_ARGS(1,2) PHPAPI zend_result php_copy_file_ctx(const char *src, const char *dest, int src_flags, php_stream_context *ctx)
Copy link
Copy Markdown
Member

@Girgias Girgias Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribute should be back propagated to php_copy_file_ex and php_copy_file

{
php_stream *srcstream = NULL, *deststream = NULL;
zend_result ret = FAILURE;
php_stream_statbuf src_s, dest_s;
int src_stat_flags = (src_flags & STREAM_DISABLE_OPEN_BASEDIR) ? PHP_STREAM_URL_STAT_IGNORE_OPEN_BASEDIR : 0;

if (!*dest) {
zend_argument_must_not_be_empty_error(2);
return FAILURE;
}
Copy link
Copy Markdown
Member

@Girgias Girgias Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this is not the call site.


switch (php_stream_stat_path_ex(src, src_stat_flags, &src_s, ctx)) {
case -1:
/* non-statable stream */
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ PHP_MINIT_FUNCTION(user_streams);

PHPAPI zend_result php_copy_file(const char *src, const char *dest);
PHPAPI zend_result php_copy_file_ex(const char *src, const char *dest, int src_flags);
PHPAPI zend_result php_copy_file_ctx(const char *src, const char *dest, int src_flags, php_stream_context *ctx);
ZEND_ATTRIBUTE_NONNULL_ARGS(1,2) PHPAPI zend_result php_copy_file_ctx(const char *src, const char *dest, int src_flags, php_stream_context *ctx);
PHPAPI void php_fstat(php_stream *stream, zval *return_value);
PHPAPI void php_flock_common(php_stream *stream, zend_long operation, uint32_t operation_arg_num,
zval *wouldblock, zval *return_value);
Expand Down
31 changes: 31 additions & 0 deletions ext/standard/tests/file/copy_empty_path.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
--TEST--
copy() throws ValueError when source or destination is empty
--FILE--
<?php

$dir = __DIR__;

file_put_contents($dir . "/foo.txt", "test");

try {
copy("", $dir . "/bar.txt");
} catch (ValueError $e) {
echo $e->getMessage(), PHP_EOL;
}

try {
copy($dir . "/foo.txt", "");
} catch (ValueError $e) {
echo $e->getMessage(), PHP_EOL;
}

?>
--CLEAN--
<?php
$dir = __DIR__;
@unlink($dir . "/foo.txt");
@unlink($dir . "/bar.txt");
?>
--EXPECT--
Path must not be empty
copy(): Argument #2 ($to) must not be empty
Loading