Fix dateformat_format_variant3 test and split into different files #20901
+439
−388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This mimics (or at least used to) an ext/date test. And I think having the ext/intl tests match the ext/date one is convenient. |
devnexen
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was really long and marked as
XFAIL. There were a few things wrong with the tests that have been fixed.Additionally the test is now split up into different files for better maintainability.
Just one note that while testing I stumbled upon the fact that
datefmt_formatputs anarrow no-break space (U+202F)between[time] PM. But not necessarily always. I have added a string replace, because I don't think it matters much for the test outcome. But it makes it much easier to verify the input/output of the tests.