Make mimalloc the default for fully static musl builds#2248
Make mimalloc the default for fully static musl builds#2248
Conversation
| if [ -z "${MIMALLOC}" ]; then | ||
| MIMALLOC=1 | ||
| fi |
There was a problem hiding this comment.
I chose to go this route so that people using the static builder themselves also get mimalloc by default. Other option was to change the default in our matrix.
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
Maybe could we also enable mimalloc in our Docker images too, or explain how to use it with Docker in the docs?
| docker cp $(docker create --name static-builder-musl dunglas/frankenphp:static-builder-musl):/go/src/app/dist/frankenphp-linux-$(uname -m) frankenphp ; docker rm static-builder-musl | ||
| ``` | ||
|
|
||
| For better performance in heavily concurrent scenarios, consider using the [mimalloc](https://github.com/microsoft/mimalloc) allocator. |
There was a problem hiding this comment.
Maybe explain now to disable it instead?
Since the Docker images link against musl dynamically, the way to use mimalloc there would be the same as with glibc (installing mimalloc and setting LD_PRELOAD). I shall document that after I get at least two prototypes for the cli rework in php-src done. |
2 participants
Thank ctrl + shift + F.
closes #2246