sigmoidalcontrastimage.xml Amend parameter names - #5751
Conversation
Integer values in the description are confusing, whereas numbers in the x.xx format seem to be perceived more easily, and the type remains consistent
| Where the midpoint of the gradient will be. This value should be in the range <literal>0.00</literal> | ||
| to <literal>1.00</literal> - multiplied by the quantum value for ImageMagick. |
There was a problem hiding this comment.
This is still super confusing to me, but I have no idea how to write it better.
| image: <literal>0.00</literal> is white; <literal>0.50</literal> is | ||
| middle-gray; <literal>1.00</literal> is black. Set <parameter>sharpen</parameter> to |
There was a problem hiding this comment.
I don't think dividing by 100 is correct here. I don't know anything about Imagick, so I think keeping it 0, 50, 100 is safer.
|
This page was based on https://phpimagick.com/Imagick/sigmoidalContrastImage?midpoint=0&sigmoidal_contrast=0.5&sharpening=Increase&image_path=Lorikeet so I think we should try to keep it the same as they document it in the official docs. It looks like we have the contrast and midpoint reversed. |
|
Honestly, I think this user note is way better at explaining it than our whole manual page: https://www.php.net/manual/en/imagick.sigmoidalcontrastimage.php#113920 The whole page needs to be rewritten. |
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
2 participants
Integer values in the description are confusing, whereas numbers in the x.xx format seem to be perceived more easily, and the type remains consistent