Document clamp function#4814
Open
kylekatarnls wants to merge 1 commit into
Open
Conversation
This was referenced Aug 10, 2025
kylekatarnls
force-pushed
the
clamp-function
branch
from
August 10, 2025 17:26
b4c8f1f to
ddab889
Compare
kylekatarnls
force-pushed
the
clamp-function
branch
2 times, most recently
from
November 19, 2025 09:41
19f924c to
1b1ac7b
Compare
kylekatarnls
marked this pull request as ready for review
December 7, 2025 15:23
lacatoire
approved these changes
Jan 29, 2026
Member
|
LGTM, clear, consistent with the RFC, the implementation, and the tests. Thanks for adding this @kylekatarnls |
nicolas-grekas
added a commit
to symfony/polyfill
that referenced
this pull request
Apr 10, 2026
This PR was merged into the 1.x branch. Discussion ---------- [8.6] Add `clamp` function RFC: https://wiki.php.net/rfc/clamp_v2 Original implementation: php/php-src#19434 Documentation: php/doc-en#4814 Commits ------- 2b4c47d [8.6] Add `clamp` function
jordikroon
requested changes
May 10, 2026
jordikroon
left a comment
jordikroon
left a comment
Member
There was a problem hiding this comment.
We cannot merge this yet as 8.6 isn't released yet.
Mostly doc style comments.
Since date comparison is a big part of this RFC. We should document this explicitly here as well. Not only within the examples section.
kylekatarnls
force-pushed
the
clamp-function
branch
5 times, most recently
from
July 18, 2026 12:55
86898b3 to
934bbb8
Compare
kylekatarnls
force-pushed
the
clamp-function
branch
from
July 18, 2026 12:56
934bbb8 to
a657da6
Compare
Contributor
Author
|
Hello @jordikroon I hope I didn't forgot any fix. FTR, the markup was inspired by min.xml and max.xml. So if those here are to be fixed, then probably the errors are to be fixed in min.xml and max.xml. |
jordikroon
approved these changes
Jul 20, 2026
jordikroon
left a comment
jordikroon
left a comment
Member
There was a problem hiding this comment.
Thank you @kylekatarnls. This looks good. This will stay open for a while but in its current state no further action required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See php/php-src#19434