feat(terminal): show a data provider's description once at the batch node#255
Merged
Merged
Conversation
…node A test's description belongs to the method, not to each data set. The terminal renderer copied it from every data set result, so a DataProvider test repeated the same description under each data set. Print it once under the batch node (the root of the data set tree) and suppress it on the individual data sets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
The terminal renderer used to copy a test's description onto every data set,
so a test with a
#[DataProvider]repeated the same description line undereach generated data set. Now the description is printed once under the batch
node (the root of the data set tree) and suppressed on the individual data
sets. A test without a data provider keeps printing its description as before.
Before:
After:
Implementation:
Formatter::formatCompactRun()into a reusable
Formatter::description().TerminalLogger::batchStartedFromInfo()now prints the description once, fromTestDefinition::getDescription()(same sourceTeamcityLoggeralready uses).TerminalLoggersuppresses the per-result description while inside a batch.Why?
The duplicated description was pure noise: identical text repeated for every
data set pushed the actual results down and made data-heavy providers hard to
read. The description belongs to the method, so it should appear once at the
root of the data set tree.
Checklist