Skip to content

Add support for Guzzle 8 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtojnar wants to merge 2 commits into
base: init
Choose a base branch
from
+4 −4
Open

Add support for Guzzle 8 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
802e7ef
tests: Add missing response to exception
jtojnar Jul 22, 2026
70abff2
Add support for Guzzle 8
jtojnar Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Promise.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ private function handleException(GuzzleExceptions\GuzzleException $exception)

if ($exception instanceof GuzzleExceptions\RequestException) {
// Make sure we have a response for the HttpException
if ($exception->hasResponse()) {
if ($exception instanceof GuzzleExceptions\ResponseException) {
return new HttplugException\HttpException(
$exception->getMessage(),
$exception->getRequest(),
Expand Down
6 changes: 3 additions & 3 deletions tests/PromiseExceptionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ public static function exceptionThatIsThrownForGuzzleExceptionProvider(): array

return [
[$request, new GuzzleExceptions\ConnectException('foo', $request), NetworkException::class],
[$request, new GuzzleExceptions\TooManyRedirectsException('foo', $request), RequestException::class],
[$request, new GuzzleExceptions\RequestException('foo', $request, $response), HttpException::class],
[$request, new GuzzleExceptions\TooManyRedirectsException('foo', $request, $response), RequestException::class],
[$request, new GuzzleExceptions\ResponseException('foo', $request, $response), HttpException::class],
[$request, new GuzzleExceptions\BadResponseException('foo', $request, $response), HttpException::class],
[$request, new GuzzleExceptions\ClientException('foo', $request, $response), HttpException::class],
[$request, new GuzzleExceptions\ServerException('foo', $request, $response), HttpException::class],
[$request, new GuzzleExceptions\TransferException('foo'), TransferException::class],
[$request, new GuzzleExceptions\TransferException('foo', $request), TransferException::class],
// check cases without response
[$request, new GuzzleExceptions\RequestException('foo', $request), RequestException::class],
[$request, new GuzzleExceptions\BadResponseException('foo', $request, $response), RequestException::class],
Expand Down