Section 9: Apply the private instead of protected rule to enum constants#151
Merged
Crell merged 1 commit intoJun 25, 2026
Conversation
Section 9 required non-public enum methods to use `private` instead of `protected` but said nothing about constants. The rationale that enums do not support inheritance so `protected` is meaningless applies equally to constants, so the omission was likely an oversight (see issue 150). While broadening the rule, I also dropped the "Methods in enums MUST follow the same guidelines as methods in classes" sentence. I first considered just adding constants to it, but that sentence was already redundant with the opening line, which states that enums follow the guidelines for classes. Spelling out "methods and constants" would only have made the duplication more obvious. So instead I collapsed it into the opening line, which now mentions class methods and constants explicitly to preserve that emphasis.
Collaborator
|
I'm good with this, but giving it a few days for the rest of the WG to comment. |
Crell
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 9 required non-public enum methods to use
privateinstead ofprotectedbut said nothing about constants. The rationale that enums do not support inheritance, soprotectedis meaningless, applies equally to constants, so the omission was likely an oversight (see issue #150).While broadening the rule, I also dropped the "Methods in enums MUST follow the same guidelines as methods in classes" sentence. I first considered just adding constants to it, but that sentence was already redundant with the opening line, which states that enums follow the guidelines for classes. Spelling out "methods and constants" would only have made the duplication more obvious. So instead I collapsed it into the opening line, which now mentions class methods and constants explicitly to preserve that emphasis. Happy to drop this second change if there is no consensus that this is an improvement to make this PR focused only on what was discussed in #150.
Fixes #150