Allow structs as select option values#468
Merged
josevalim merged 1 commit intophoenixframework:mainfrom Sep 21, 2025
Merged
Conversation
josevalim
reviewed
Sep 20, 2025
Member
|
@ryanwinchester oops, can you please run the formatter? 😬 |
99b2911 to
7106001
Compare
7106001 to
c376974
Compare
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
If I try to use a select with struct values, I get an error because of an
is_mapcheck, and assumes that it is an option group.We should be able to pass as values any struct that implements the
Phoenix.HTML.Safeprotocol.Changes