Add Phoenix.HTML.Safe to Duration

[joshua-bouv]

I was creating a form which had a set of options, the values being durations

<.input
  label="Duration"
  field={@form[:duration]}
  type="select"
  options={[
    {"Daily", Duration.new!(day: 1)},
    {"Weekly", Duration.new!(week: 1)},
    {"Monthly", Duration.new!(month: 1)},
    {"Yearly", Duration.new!(year: 1)}
  ]}
/>

Duration has to_iso8601 and from_iso8601 functions so I assumed this would work like Date and Time does (auto converts to ISO), but Phoenix.HTML.Safe hadn't been implemented for Duration causing this error: protocol Phoenix.HTML.Safe not implemented for type Duration (a struct).

This PR adds the Phoenix.HTML.Safe implentation. Their might of been a reason why this wasn't added originally though, but im not too sure why that could be?

[SteffenDE]

The minimum supported Elixir version is 1.7 at the moment

phoenix_html/mix.exs

Line 12 in c11a9e3

elixir: "~> 1.7",

which does not know anything about Duration, so we might need to conditionally define this? @josevalim

[joshua-bouv]

The minimum supported Elixir version is 1.7 at the moment

phoenix_html/mix.exs

Line 12 in c11a9e3

elixir: "~> 1.7",

which does not know anything about Duration, so we might need to conditionally define this? @josevalim

Good spot!

If the decision is to addif Version.match?(System.version(), ">= 1.17.0") do around the function (and test) I have the commit on stand-by 👍

[josevalim]

I am almost sure that previous Elixir versions did not complain if you implemented a protocol for a module/struct that was not available. But this has changed on v1.18 or 1.19 because of the type system. Let's see what CI says.

[josevalim]

@joshua-bouv yeah, you will need to wrap both the definition and the tests in if Code.ensure_loaded?(Duration) do blocks. :)

[joshua-bouv]

Done 👍

[josevalim]

💚 💙 💜 💛 ❤️