Fix OOM in Runner Node killing FLAME Pool#87
Open
Lakret wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First reported in #66.
I have also encountered this error when testing my DinD backend for FLAME in one of my apps.
After further investigation, it seems that the issue is due to a race condition in
FLAME.Pool.checkin_runner/4: if the caller is already dropped with thereason == :catch, the Pool process crashes withArgumentError, which leads to the :ets table being absent for the following calls. Instead of crashing, this fix just executesmaybe_drop_waiting/2irrespective of the reason.P.S. After fixing this issue, I noticed another issue: apparently FLAME Runner node going down can cause all other Runner nodes disconnecting due to prevent_overlapping_partitions logic in the :global module. It's outside the scope of this PR, but if you are encountering this issue, there are two ways to fix it:
-kernel prevent_overlapping_partitions falseinrel/vm.args.eex(if you are using releases to deploy)Overall, after testing the changes in this PR in my app, the original problem is solved - Pool doesn't crash on Runner's OOMs anymore.