Create a sprite sheet for map resource pins#707
Merged
Conversation
AnilKumar3494
approved these changes
Feb 16, 2026
| isActiveMarker ? 'active' : 'default' | ||
| }`; | ||
|
|
||
| const size = isActiveMarker ? 63 : 57; |
Member
There was a problem hiding this comment.
maybe can make size 80 or 85 when active. This kinda makes my visual intuition satisfied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Change Summary
index.htmllevel so it's cachedIconcomponent that accesses SVG symbols from a sprite sheetChange Reason
There was too much complexity and performance issues for loading the map resource icons.
This approach results in fewer asset files, shorter load times, and no need to generate SVG components.