Skip to content

LP Edit polishing #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 17 commits into from
Nov 24, 2025

fix: info box is getting triggered for phoenix internal elements

649379f
Select commit
Loading
Failed to load commit list.
Merged

LP Edit polishing #2488

fix: info box is getting triggered for phoenix internal elements
649379f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 23, 2025 in 42s

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 472 in src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqrUhm81NG8ykCpyNoJ&open=AZqrUhm81NG8ykCpyNoJ&pullRequest=2488

Check warning on line 469 in src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqrUhm81NG8ykCpyNoG&open=AZqrUhm81NG8ykCpyNoG&pullRequest=2488

Check failure on line 1745 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `setAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqyMMz1XrFv6bfNgNEC&open=AZqyMMz1XrFv6bfNgNEC&pullRequest=2488

Check failure on line 468 in src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `hasAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqrUhm81NG8ykCpyNoF&open=AZqrUhm81NG8ykCpyNoF&pullRequest=2488

Check warning on line 470 in src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqrUhm81NG8ykCpyNoI&open=AZqrUhm81NG8ykCpyNoI&pullRequest=2488

Check failure on line 1930 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `setAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqyMMz1XrFv6bfNgNED&open=AZqyMMz1XrFv6bfNgNED&pullRequest=2488

Check failure on line 1465 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `setAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqyMMz1XrFv6bfNgNEB&open=AZqyMMz1XrFv6bfNgNEB&pullRequest=2488

Check warning on line 4627 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqwG97RhJMJg08I7hbC&open=AZqwG97RhJMJg08I7hbC&pullRequest=2488

Check warning on line 1290 in src/LiveDevelopment/LivePreviewEdit.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move function '_handlePreviewModeToggle' to the outer scope. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqs3Y7X1NG8ykCp55xm&open=AZqs3Y7X1NG8ykCp55xm&pullRequest=2488

Check failure on line 4564 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `setAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqyMMz1XrFv6bfNgNEF&open=AZqyMMz1XrFv6bfNgNEF&pullRequest=2488

Check warning on line 1280 in src/LiveDevelopment/LivePreviewEdit.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqsvvDi8JCxfjKb_FNQ&open=AZqsvvDi8JCxfjKb_FNQ&pullRequest=2488

Check warning on line 470 in src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqrUhm81NG8ykCpyNoH&open=AZqrUhm81NG8ykCpyNoH&pullRequest=2488

Check failure on line 2300 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `setAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZqyMMz1XrFv6bfNgNEE&open=AZqyMMz1XrFv6bfNgNEE&pullRequest=2488
View more details on SonarQubeCloud