Conversation
…everything to click handler
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes tab bar issues.
1st commit: sometimes when right-clicking on tabs used to open the editor's context menu instead of the tab bar context menu. Fixed it.
2nd commit: Rewrote drag-drop for tab bar, as earlier drag-drop had some issues like drop indicator not appearing at expected places, etc
3rd commit: fix small typo in comment
4th commit: This was a very important fix. The issue was that when the overflow button was clicked, the dropdown appeared. However, clicking it again (while it was still visible) did not close it as expected. Fixed it!
5th commit: Sometimes when (ANY) dropdown was open and a tab was clicked the tab didn't become active, found that mousedown event was not getting triggered. so moved the whole logic to click. now things work fine.
6th commit: test failed as replaced mousedown with click. fixed the test.
7th commit: add missing localization for overflow button tooltip
8th commit: when clicking tabs in inactive panes, the click handler wasn't running because activePaneChange immediately rebuilt the DOM, because of which the click handler was destroyed and the right tab was not becoming active. fixed it