Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of git panel not getting updated properly when changes were made from external sources.
Before
Earlier, we had a 5seconds of focus switch dedupe time. The problem with this was that if user switch from the external source to Phoenix very quickly (maybe right after executing the command) then we were not refreshing the Git as it had a timer. Secondly, the hasStatusChanged only tracked for commit changes, and not the push/pull and other changes, that also prevented the panel to update when needed.
After
Now, when Phoenix gains focus, we check if the git panel is open. If its open it likely means that user performed some git changes externally, so we refresh the git panel. But if the git panel is not open, we just refresh the branch. This approach makes sure that we don't call the expensive REFRESH_ALL all the time when unintended. We call it only when its very likely that it should be updated.