-
-
Notifications
You must be signed in to change notification settings - Fork 192
Live Preview #2332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Live Preview #2332
Changes from all commits
Commits
Show all changes
142 commits
Select commit
Hold shift + click to select a range
6e2c3dc
feat: live preview hover inspect ui initial
abose c8a0710
feat: live preview hover highlights improved
abose addf4c2
feat: element selection and content editable setting
abose 98ddfb9
feat: create the DOM manipulation option box when an element is click…
devvaannsh 07c32a0
feat: add click handler to the DOM advance option buttons
devvaannsh d84ae16
fix: dom more options box background color changing when hovered
devvaannsh 24abd1f
feat: add border when a element is clicked
devvaannsh f7cd3f7
fix: change border to outline to prevent content shifting
devvaannsh 4451767
fix: more options box positioning when live preview is scrolled
devvaannsh b6f481a
fix: offset height gives invalid px and puts the more options box bel…
devvaannsh e10e89d
fix: box getting out of viewport horizontally
devvaannsh 22a16a4
fix: positioning of the element info box
devvaannsh 6a661bd
fix: horizontal positioning of both the boxes
devvaannsh 7fe3498
feat: enable deletion of elements in source code from live preview
devvaannsh 8451ee0
fix: use existing APIs to reference the source code of the element gi…
devvaannsh 42c5178
fix: remove the popup after it is handled
devvaannsh ff22ce6
feat: implement live preview duplicate option functionality
devvaannsh a5d982f
feat: implement select-parent option in live preview edit
devvaannsh 0cc7413
fix: implement shadow DOM to prevent box styles being overridden by u…
devvaannsh 444d009
fix: box now moves along with the selected element when scrolled
devvaannsh 735627f
fix: positioning of the info box
devvaannsh c2f8cad
fix: remove properties after setting values
devvaannsh 25d823c
feat: add event listener for dragging inside live preview
devvaannsh 29df4b8
feat: implement live preview edit text functionality
devvaannsh db02790
fix: duplication issue when there is some content before the element
devvaannsh 1794526
fix: disbale live preview edit for html & body tags
devvaannsh d4b0e20
fix: show more options box at the correct position when live preview …
devvaannsh 216c83d
fix: bold italic type of tags break inside live preview and leaks int…
devvaannsh d37c0d3
fix: use current live doc instead of active editor
devvaannsh 186c5ae
fix: editing text inside live preview leaks phoenix internal attributes
devvaannsh baae736
fix: file rename to make it consistent
devvaannsh 1159d1a
fix: typo in file name
devvaannsh ebc68ae
fix: show info box along with more option box when a DOM element is c…
devvaannsh 3fb7175
fix: overlapping issue between the info box and the more options box
devvaannsh d222ea6
fix: calculate info box width based on char count
devvaannsh fdaa01a
fix: positioning of the info box
devvaannsh dca465f
fix: info box getting out of bounds
devvaannsh 80bbb32
fix: remove redundant positioning checks
devvaannsh 2e7ea12
feat: enable undo in live preview to undo live preview edit operations
devvaannsh f9df628
feat: drag drop live preview implementation
devvaannsh bc07af8
fix: indent of target element after drag & drop operation
devvaannsh 06f2944
feat: allow dropping before as well as after the element
devvaannsh e832ac2
fix: internal live preview editing styles leak on users source code
devvaannsh d91dc27
fix: remove extra line after drag-drop operation
devvaannsh 1d7f006
feat: remove boxes when escape key is pressed or user clicks on a emp…
devvaannsh 898ace0
fix: delete empty lines when deleting an element from the live preview
devvaannsh e78ec69
fix: error when trying to remove node info box
devvaannsh 85d08de
fix: live preview not handling escape keypress when highlight pref is on
devvaannsh 6823f6a
feat: enable redo when ctrl + y is pressed in live preview
devvaannsh 9b47097
fix: prevent links and buttons to move to another webpage when edit m…
devvaannsh 0eea051
feat: add pen icon to edit text in the more options box
devvaannsh 8662ebc
fix: more options box doesn't appear because click event was removed
devvaannsh 1ecee71
fix: do delete and duplicate operation in batch so that undo and redo…
devvaannsh f8d2e96
feat: hide edit option when element is non-editable
devvaannsh a007746
feat: hide select-parent option when element doesn't supports it
devvaannsh 19755fb
fix: unable to edit text inside elements with no text content
devvaannsh c1f5191
fix: more options box gets out of viewport with very long elements
devvaannsh cb92fa1
fix: button's onclick was overriding more options box
devvaannsh a38b2f9
fix: revert code as it broke the existing tests
devvaannsh 7f4c6cd
fix: more option box reappearing after operation performed
devvaannsh 218b316
fix: info box not visible in viewport when element is at the very bottom
devvaannsh ab82a76
fix: more options box not getting hidden after drag & drop operation
devvaannsh 72e5d72
fix: make sure info box is within live preview bounds
devvaannsh 44699c5
fix: remove boxes when user scrolls the live preview
devvaannsh 518d693
fix: remove more options box when user starts editing
devvaannsh 29f5f2d
fix: drag & drop logic breaks when target is after source
devvaannsh 4de8d9a
fix: move cursor to end of the text content when editing a text
devvaannsh 52d90c9
fix: unable to select text because start editing was called again and…
devvaannsh bb9c0cc
fix: text content becomes undefined when user presses escape
devvaannsh 4f37db1
fix: duplication and deletion gives syntax error when code is not bea…
devvaannsh c24875a
fix: use start range from instead of the current cursor position to f…
devvaannsh 018a586
fix: use findMatchingTag to get the end position as it is more robust
devvaannsh 4fc035e
fix: fix architecture of move function by using the getMatchingTag fu…
devvaannsh ae230ea
fix: browser removing incorrect css syntax from code which is uninten…
devvaannsh 3808094
refactor: remove dead code
devvaannsh 36a0fdd
fix: operations doesn't work for empty tags as we were relying on the…
devvaannsh 943f651
refactor: allow buttons to be editable
devvaannsh e67fd2d
fix: text formatting not working when trying to edit text in live pre…
devvaannsh cd61d01
fix: body tag gets removed from source code when trying to edit a bod…
devvaannsh d099ba2
refactor: calculate the position of the boxes
devvaannsh 964d62f
fix: move boxes to down when no space at top
devvaannsh 1b1ade5
feat: update background color when a option button is hovered
devvaannsh b3bc4d1
fix: positioning of the info box
devvaannsh 31a9f7b
fix: node more options box positioning
devvaannsh 7e4508d
fix: boxes overlapping each other
devvaannsh 8960285
fix: use screenOffset to calculate overflow
devvaannsh 6bfc561
fix: phoenix internal attributes leaking into users source code
devvaannsh 7c965ee
fix: boxes gets out of viewport
devvaannsh a1501b1
feat: disable all the live preview advance features when its disabled
devvaannsh 2c0130a
feat: add a setting to show elements highlights on hover or click
devvaannsh 899728d
feat: change live preview effect when setting is changed
devvaannsh 840b701
fix: element highlights setting not getting applied immediately directly
devvaannsh 9c8859f
feat: add strings for elements highlight feature
devvaannsh bfd3c16
feat: improve styles for element highlight setting
devvaannsh 81a2216
fix: make sure the info box never gets out of bounds
devvaannsh baaf59f
feat: show element highlights boxes when user edits source code for a…
devvaannsh 75be123
fix: don't remove the boxes when the preview is scrolled
devvaannsh 276979f
fix: don't show boxes on non-existant elements
devvaannsh a341479
fix: cursor jump to that start of element when an element in clicked …
devvaannsh 97fb92d
fix: don't show UI boxes when element is hidden
devvaannsh 8b30015
refactor: update duplicate icon
devvaannsh bcf9736
fix: live preview jumping automatically
devvaannsh a210f97
feat: advance drag-drop implementation
devvaannsh 1d6fd2e
refactor: make code more DRY
devvaannsh 8dead8c
fix: indentation not consistent after drag-drop
devvaannsh a968827
fix: boxes drifts away from elements when elements are fixed positioned
devvaannsh fa1c4f4
fix: don't close popup after duplicate operation
devvaannsh 1fab5c6
fix: data-ld-highlight attribute leaks in the source code
devvaannsh b226601
fix: drag-drop causing elements to disappear when target is inside so…
devvaannsh 13037e0
fix: get actual indent instead of assuming it to be 4 spaces
devvaannsh 65704aa
fix: boxes disappear when scrolling too slow
devvaannsh e8deb87
fix: drag markers not getting positioned correctly when webpage has f…
devvaannsh 802a353
fix: boxes overlapping when triggered for different elements
devvaannsh 53aff27
feat: allow auto scrolling when on viewport edges
devvaannsh 678df80
fix: when highlight is set to false livePreviewEdit on hover also sto…
devvaannsh edd0d82
fix: background color from some elements doesn't get removed when con…
devvaannsh c3127a6
feat: add select mode button in the live preview toolbar
devvaannsh 482cbea
chore: remove highlights button from live preview toolbar
devvaannsh 51da71b
fix: remove markers and highlights when edit mode is disabled
devvaannsh e629173
fix: flickering issue with very long elements
devvaannsh adf0e43
feat: add preview mode option in live preview
devvaannsh 5dc3885
feat: add AI prompt box in live preview
devvaannsh efd41fc
feat: add live preview mode settings to preferences
devvaannsh 014044f
feat: move all the strings to strings.js file
devvaannsh 97bcc75
refactor: clean the select parent function
devvaannsh 0e4a28c
feat: move edit elements on hover from settings to dropdown
devvaannsh 782048c
fix: clean dirty icons when no changes are made in the editor
devvaannsh 855eb85
fix: error when click highlight is null and adding a selector to that
devvaannsh 981da5d
feat: add checkmark icon in the current active mode
devvaannsh 8859176
fix: ai box width set on smaller screens
devvaannsh cd1b780
feat: show pro icon on edit mode
devvaannsh 0eee7dd
feat: send data to AI when element is edited with AI
devvaannsh 0b871bc
feat: show dialog when subscribe button is clicked
devvaannsh b3a587d
feat: allow selecting model when sending message to AI
devvaannsh d4a86c9
fix: background color doesn't get removed when switching from edit mo…
devvaannsh 659853c
fix: user styles overriding our elements styling
devvaannsh d23af23
chore: move strings to related strings file
devvaannsh 87261a0
fix: minor styling fixes
devvaannsh 1a929d1
refactor: make highlight/edit mode as default when edit features are …
devvaannsh e63a372
fix: tests failing because of edit mode default behaviour
devvaannsh a9db70d
fix: drag operating affecting styles permanently for some elements
devvaannsh cccc40f
chore: retrigger CI after base moved
abose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to consider these playform specific shortcuts.Here’s the standard set of undo/redo shortcuts across major platforms:
Undo
Ctrl + ZCmd (⌘) + ZRedo
There are two conventions for redo, depending on app:
Windows / Linux:
Ctrl + YCtrl + Shift + ZmacOS:
Cmd (⌘) + Shift + ZSo the general pattern is:
Ctrl/Cmd + ZCtrl + Y(Win/Linux) orCmd + Shift + Z(Mac), with some editors preferringCtrl + Shift + Zeverywhere for consistency.