Skip to content

Fixed UI issues with emmet code hints in HTML files #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 3 commits into from
May 31, 2025
Merged

Fixed UI issues with emmet code hints in HTML files #2279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cff8e6
fix: update emmet icon in html files to make it consistent to css emm…
devvaannsh May 29, 2025
36bb0ea
fix: give max-width to emmet for html so that it doesn't cover up the…
devvaannsh May 29, 2025
97b6ef8
fix: remove redundant max-width class from dropdown menu
devvaannsh May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/extensions/default/HTMLCodeHints/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,20 @@ define(function (require, exports, module) {
* @returns {jQuery} - A jQuery element representing the formatted hint.
*/
function formatEmmetHint(abbr) {
// Create the main container for the hint text.
// Create the main container for the hint
var $hint = $("<span>")
.addClass("emmet-hint")
.addClass("emmet-hint");

// Create a wrapper for the text content
var $textContent = $("<span>")
.addClass("emmet-text-content")
.text(abbr);

// style in brackets_patterns_override.less file
let $icon = $(`<span class="emmet-code-hint">Emmet</span>`);

// Append the icon to the hint element
// Append both text content and icon to the main container
$hint.append($textContent);
$hint.append($icon);

return $hint;
Expand Down
27 changes: 21 additions & 6 deletions src/styles/brackets_patterns_override.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,22 +727,37 @@ a:focus {
}
}

.emmet-hint {
margin-right: 48px !important;
.emmet-code-hint {
visibility: hidden;
}

.emmet-code-hint {
.codehint-menu .dropdown-menu li a.highlight .emmet-code-hint {
visibility: visible;
position: absolute;
font-size: 0.85em;
right: 1rem;
font-size: 0.85em !important;
font-weight: @font-weight-semibold;
right: 4px;
bottom: 0px;
letter-spacing: 0.3px;
color: @css-codehint-icon !important;
.dark& {
color: @dark-css-codehint-icon !important;
}
}

.emmet-hint {
margin-right: 48px !important;
}

.emmet-text-content {
display: inline-block;
max-width: 320px;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
vertical-align: top;
line-height: inherit;
}

#codehint-desc {
background: @bc-codehint-desc;
position: absolute;
Expand Down
Loading