Conversation
…preference. numberOfTabs
|
abose
approved these changes
May 21, 2025
| // Current active pane (used to determine whether to add the blue underline) | ||
| const currentActivePane = MainViewManager.getActivePaneId(); | ||
| const isPaneActive = (paneId === currentActivePane); | ||
| const isPaneActive = paneId === currentActivePane; |
Member
There was a problem hiding this comment.
const isPaneActive = (paneId === currentActivePane); this with explicit braces is preferred over implicit to be more readable and prevent operator precedence confusions. i think this came as part of a whole file beautify. Just FYI, no need to update this pr.
| ${isActive ? 'active' : ''} | ||
| ${isDirty ? 'dirty' : ''} | ||
| ${isPlaceholder ? 'placeholder' : ''}" | ||
| ${isActive ? "active" : ""} |
Member
There was a problem hiding this comment.
Avoid using full file beautify as part of pull requests as it create too many non related changes to review that is hard to review.
| function handleFileRename(filePath) { | ||
| if (filePath) { | ||
| // First ensure the sidebar is visible so users can see the rename action | ||
| CommandManager.execute(Commands.SHOW_SIDEBAR); |
Member
There was a problem hiding this comment.
This is a good check, i guess this can be moved to the core itself as part of the underlying command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
https://github.com/user-attachments/assets/50ff6184-081f-4bfe-82b1-facbb1c83ade
After
https://github.com/user-attachments/assets/5ed7b0c4-bd4a-4eae-b53c-7c15ec2d9e74
Add option to rename, delete file and show in file tree in the tab context menu
Made drag-drop scroll smoother
Currently active tab is always shown on the tab bar even if user manually sets a number in the numberOfTabs preference option
Fix: Now, we show the display path when a tab is hovered instead of the tauri path
We also show the git change markers in the tab to visually identify the tab that is added/modified