Skip to content

feat: go to line will accept :ln:col format along with :ln,col #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 1 commit into from
Jan 16, 2025
Merged

feat: go to line will accept :ln:col format along with :ln,col #2061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/search/QuickOpen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ define(function (require, exports, module) {
* @private
* @const {RegExp}
*/
var CURSOR_POS_EXP = new RegExp(":([^,]+)?(,(.+)?)?");
var CURSOR_POS_EXP = new RegExp(":([^,:]+)?([,:](.+)?)?");

/**
* Current plugin
Expand Down
16 changes: 16 additions & 0 deletions test/spec/QuickOpen-integ-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,5 +182,21 @@ define(function (require, exports, module) {
it("can directly open a file in a given line and column, centering that line on the screen", async function () {
await quickOpenTest("lines:150,20", null, "lotsOfLines.html", 150, 20);
});

it("can open a file and jump to a line and column with no space after comma", async function () {
await quickOpenTest("lines", ":50,20", "lotsOfLines.html", 50, 20);
});

it("can open a file and jump to a line and column with space after comma", async function () {
await quickOpenTest("lines", ":50, 20", "lotsOfLines.html", 50, 20);
});

it("can directly open a file with line:column format", async function () {
await quickOpenTest("lines:150:20", null, "lotsOfLines.html", 150, 20);
});

it("can directly open a file with line:column format and spaces", async function () {
await quickOpenTest("lines:150: 20", null, "lotsOfLines.html", 150, 20);
});
});
});
Loading