Skip to content

fix: update virtual path before displaying in the UI #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 1 commit into from
Jan 9, 2025
Merged

fix: update virtual path before displaying in the UI #2037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/extensionsIntegrated/NavigationAndHistory/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,14 @@ define(function (require, exports, module) {
}

$newItem.data("path", value.file);

// convert the virtual path to display path
var displayPath = Phoenix.app.getDisplayPath(value.file);

$newItem.data("paneId", value.paneId);
$newItem.data("cursor", value.cursor);
$newItem.data("file", fileEntry);
$newItem.attr("title", value.file);
$newItem.attr("title", displayPath); // this is for the tooltip

if (isPaneLabelReqd && value.paneId) {
$newItem.addClass(value.paneId);
Expand Down Expand Up @@ -442,8 +446,12 @@ define(function (require, exports, module) {
var $scope = $(event.target).parent();
$("#mrof-container #mrof-list > li.highlight").removeClass("highlight");
$(event.target).parent().addClass("highlight");
$mrofContainer.find("#recent-file-path").text($scope.data("path"));
$mrofContainer.find("#recent-file-path").attr('title', ($scope.data("path")));

// convert the virtual path to display path
var displayPath = Phoenix.app.getDisplayPath($scope.data("path"));
$mrofContainer.find("#recent-file-path").text(displayPath);
$mrofContainer.find("#recent-file-path").attr('title', displayPath);

$currentContext = $scope;
}

Expand Down
Loading