Update pick/weightedPick typings to accept array-like objects#7258
Open
Bertie690 wants to merge 4 commits into
Open
Update pick/weightedPick typings to accept array-like objects#7258Bertie690 wants to merge 4 commits into
pick/weightedPick typings to accept array-like objects#7258Bertie690 wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 126152d. Configure here.
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #7257
This PR:
Describe the changes below:
Updated typings of relevant methods to allow passing in array-like objects like
TypedArrayandreadonlyarrays. (At runtime, all we require is a numericlengthand numeric index support, so array-like objects work just fine here.)Note
Medium Risk
TypeScript declaration changes affect public API typings for
RandomDataGenerator; while runtime behavior is unchanged, the updated signatures (and thesign()typing/doc change) could impact downstream TS compile behavior and type safety.Overview
Updates
RandomDataGeneratorpickandweightedPickto be documented/typed as acceptingArrayLike<T>(e.g., typed arrays/readonly arrays) instead of onlyT[].Also adjusts return typing/docs for
sign()in JS docs (to-1 | 1) and intypes/phaser.d.ts(nowsign(): anywith an updated@returns), plus a few minor@returnsdoc formatting tweaks elsewhere in the d.ts file.Reviewed by Cursor Bugbot for commit 126152d. Bugbot is set up for automated code reviews on this repo. Configure here.