Open
Conversation
Member
Author
|
Tests are failing due to ariya/phantomjs#11637. Other drivers it seem will happily click on the first link with a matching title (eg, the 'my account' link is on the page twice, the first one hidden via js, the second always available). I'm going to update the test to work around this, but that limitation may be enough reason not to default to phantomjs. |
grayside
previously requested changes
Aug 29, 2017
Contributor
grayside
left a comment
grayside
left a comment
There was a problem hiding this comment.
Not sure if this should instead be closed, but leaving it pending completion in case it can help jumpstart a new round of work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial research and work for issue #247.