chore(SEC-10458): upgrade axios to 1.15.2#36
chore(SEC-10458): upgrade axios to 1.15.2#36phantom-autopilot[bot] wants to merge 1 commit intodevfrom
Conversation
Resolves GHSA-q8qp-cvcw-x6jj (HIGH) — prototype pollution read-side gadgets in axios HTTP adapter allowing credential injection / request hijacking. Vulnerable range: >=1.0.0,<1.15.2. - Bump direct dependency `axios` from ^1.4.0 to ^1.15.2. - Add `axios: 1.15.2` to `resolutions` to override the exact 1.2.2 pin from `etherscan-api@10.3.0` (no newer version of etherscan-api is published that loosens this constraint). - Lockfile now resolves a single axios entry at 1.15.2; the previous 1.2.2 and 1.7.7 versions are removed.
|
PR opened by agent |
📝 WalkthroughWalkthroughThe PR upgrades the axios dependency from ^1.4.0 to ^1.15.2 and adds an explicit resolution pin to version 1.15.2 to enforce consistent dependency resolution across the project's dependency tree. ChangesDependency and Resolution Update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Pushed commit Commit, push, open draft PR PR opened by agent PR: #36 (draft, base dev). The etherscan-api@10.3.0 exact pin on axios@1.2.2 had no upstream-loosened release available, so a resolutions override was the only viable path — flagged that explicitly in the PR body and Linear comment. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
108-116:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd axios to overrides to enforce the security fix across all package manager paths.
Line 113 pins axios to 1.15.2 (SEC-10458 security fix) via Yarn
resolutions, but the project also runs pnpm (lines 37, 40–46, Dockerfile, pnpm-lock.yaml). Theresolutionsfield only applies to Yarn; pnpm respectsoverrides. Without axios inoverrides, pnpm-based installs may resolve a different axios version, bypassing the security patch.Suggested patch
"overrides": { + "axios": "1.15.2", "lodash@<4.17.20": "4.17.20" },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 108 - 116, The package.json currently pins axios in "resolutions" but not in "overrides", so pnpm installs may not get the security-pinned axios; add an "axios": "1.15.2" entry to the existing "overrides" object (alongside the existing lodash override) so both Yarn (resolutions) and pnpm (overrides) enforce the same axios version; ensure the version string matches the resolutions entry and valid JSON object syntax in the "overrides" block.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@package.json`:
- Around line 108-116: The package.json currently pins axios in "resolutions"
but not in "overrides", so pnpm installs may not get the security-pinned axios;
add an "axios": "1.15.2" entry to the existing "overrides" object (alongside the
existing lodash override) so both Yarn (resolutions) and pnpm (overrides)
enforce the same axios version; ensure the version string matches the
resolutions entry and valid JSON object syntax in the "overrides" block.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d252877e-cc1a-499f-98e8-547703d6db4e
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json
Summary
Resolves Linear ticket SEC-10458 — upgrade
axiosto 1.15.2 to remediate GHSA-q8qp-cvcw-x6jj (CVE-2026-42264, HIGH).Changes
package.json: bump direct depaxiosfrom^1.4.0→^1.15.2.package.json: addaxios: "1.15.2"toresolutionsto override the exact1.2.2pin inetherscan-api@10.3.0. The latest publishedetherscan-apiis10.3.0and still pinsaxios: "1.2.2", so aresolutionsoverride is the only viable path.yarn.lock: regenerated. The lockfile now resolves a singleaxios@1.15.2— the prior1.2.2and1.7.7entries are removed.Compatibility check
Direct dependencies that reference axios:
axios(direct) — bumped to^1.15.2✅etherscan-api@10.3.0— pinsaxios: 1.2.2exactly. No newer release exists; resolved viaresolutions✅wait-on@^7.0.1— declaresaxios: ^1.6.1, satisfied by 1.15.2 ✅Test plan
yarninstall — no resolution failures.yarn lintpasses (no application code changes).wait-on/etherscan-api/ direct usage; axios 1.x is API-stable.🤖 Generated with Claude Code
Summary by CodeRabbit