fix: set block explorer URL after successful transaction#388
Open
pete-watters wants to merge 2 commits intophantom:mainfrom
Open
fix: set block explorer URL after successful transaction#388pete-watters wants to merge 2 commits intophantom:mainfrom
pete-watters wants to merge 2 commits intophantom:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single file update in the React Native SDK demo app where the transaction explorer URL is now populated with a Solscan link based on the transaction signature after successful transactions, rather than being cleared to null. Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copilot |
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The wallet screen includes a "View on Block Explorer" button that is rendered conditionally when
transactionExploreris set. After a successful transaction, the code sets this tonull, so the button never appears.To fix this, I changed it to set
transactionExplorerto the Solscan URL using the transaction signature, consistent with how the constants package defines Solana explorer URLs inNETWORK_CONFIGS.How I Tested These Changes
I tested this purely using code type checks.
result.signatureis already used in the success message on the line above — this just passes it to a Solscan URL instead of discarding it.To manually test it I got the APP running locally and set up a project on the developer portal however I am continually seeing an error that 'The redirect URI 'phantom-rn-demo://phantom-auth-callback' is not whitelisted for this application.
Did you add a changeset?
This change is isolated to the
examplesso I did not add a changeset - no package code is modified.Did you update the README files?
I did not, as this is adding a bug fix
Summary by CodeRabbit